You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rd...@apache.org on 2008/09/15 21:51:11 UTC

svn commit: r695596 - in /james/protocols/imap/trunk: mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java

Author: rdonkin
Date: Mon Sep 15 12:51:10 2008
New Revision: 695596

URL: http://svn.apache.org/viewvc?rev=695596&view=rev
Log:
Note a few deprecations to be removed later

Modified:
    james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java
    james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java

Modified: james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java
URL: http://svn.apache.org/viewvc/james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java?rev=695596&r1=695595&r2=695596&view=diff
==============================================================================
--- james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java (original)
+++ james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java Mon Sep 15 12:51:10 2008
@@ -22,7 +22,10 @@
 import org.apache.james.mailboxmanager.MailboxManagerException;
 
 public interface MailboxManagerProvider {
-    
+
+	/**
+	 * @deprecated remove avalon coupling
+	 */
     public static final String ROLE 
         =  "org.apache.james.mailboxmanager.manager.MailboxManagerProvider";
     

Modified: james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java
URL: http://svn.apache.org/viewvc/james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java?rev=695596&r1=695595&r2=695596&view=diff
==============================================================================
--- james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java (original)
+++ james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java Mon Sep 15 12:51:10 2008
@@ -27,6 +27,7 @@
 /**
  * Provides a number of server-wide constant values to the
  * POP3Handlers
+ * @deprecated unnecessary
  */
 public interface ImapHandlerConfigurationData
 {



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: svn commit: r695596 - in /james/protocols/imap/trunk: mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java

Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Mon, Sep 15, 2008 at 9:14 PM, Stefano Bagnara <ap...@bago.org> wrote:
> rdonkin@apache.org ha scritto:
>>
>> Author: rdonkin
>> Date: Mon Sep 15 12:51:10 2008
>> New Revision: 695596
>>
>> URL: http://svn.apache.org/viewvc?rev=695596&view=rev
>> Log:
>> Note a few deprecations to be removed later
>>
>> Modified:
>>
>>  james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java
>>
>>  james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java
>>
>> Modified:
>> james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java
>> URL:
>> http://svn.apache.org/viewvc/james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java?rev=695596&r1=695595&r2=695596&view=diff
>>
>> ==============================================================================
>> ---
>> james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java
>> (original)
>> +++
>> james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java
>> Mon Sep 15 12:51:10 2008
>> @@ -22,7 +22,10 @@
>>  import org.apache.james.mailboxmanager.MailboxManagerException;
>>   public interface MailboxManagerProvider {
>> -    +
>> +       /**
>> +        * @deprecated remove avalon coupling
>> +        */
>>     public static final String ROLE         =
>>  "org.apache.james.mailboxmanager.manager.MailboxManagerProvider";
>
> You can remove this at all. ROLE is not needed by phoenix/avalon and this is
> unrealeased code. We can use MailboxManagerProvider.class.getName() instead
> of MailboxManagerProvider.ROLE, or use simply the string instead of
> MailboxManagerProvider.ROLE.

i'm just deprecating ATM for convenience. i'll remove once i'm ready.

>> Modified:
>> james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java
>> URL:
>> http://svn.apache.org/viewvc/james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java?rev=695596&r1=695595&r2=695596&view=diff
>>
>> ==============================================================================
>> ---
>> james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java
>> (original)
>> +++
>> james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java
>> Mon Sep 15 12:51:10 2008
>> @@ -27,6 +27,7 @@
>>  /**
>>  * Provides a number of server-wide constant values to the
>>  * POP3Handlers
>> + * @deprecated unnecessary
>>  */
>>  public interface ImapHandlerConfigurationData
>>  {
>
> I just noticed the javadoc is about POP3.

yep

once i've finished rationalising the imapserver-function, this class can go

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: svn commit: r695596 - in /james/protocols/imap/trunk: mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java

Posted by Stefano Bagnara <ap...@bago.org>.
rdonkin@apache.org ha scritto:
> Author: rdonkin
> Date: Mon Sep 15 12:51:10 2008
> New Revision: 695596
> 
> URL: http://svn.apache.org/viewvc?rev=695596&view=rev
> Log:
> Note a few deprecations to be removed later
> 
> Modified:
>     james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java
>     james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java
> 
> Modified: james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java
> URL: http://svn.apache.org/viewvc/james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java?rev=695596&r1=695595&r2=695596&view=diff
> ==============================================================================
> --- james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java (original)
> +++ james/protocols/imap/trunk/mailbox/src/main/java/org/apache/james/mailboxmanager/manager/MailboxManagerProvider.java Mon Sep 15 12:51:10 2008
> @@ -22,7 +22,10 @@
>  import org.apache.james.mailboxmanager.MailboxManagerException;
>  
>  public interface MailboxManagerProvider {
> -    
> +
> +	/**
> +	 * @deprecated remove avalon coupling
> +	 */
>      public static final String ROLE 
>          =  "org.apache.james.mailboxmanager.manager.MailboxManagerProvider";

You can remove this at all. ROLE is not needed by phoenix/avalon and 
this is unrealeased code. We can use 
MailboxManagerProvider.class.getName() instead of 
MailboxManagerProvider.ROLE, or use simply the string instead of 
MailboxManagerProvider.ROLE.

> Modified: james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java
> URL: http://svn.apache.org/viewvc/james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java?rev=695596&r1=695595&r2=695596&view=diff
> ==============================================================================
> --- james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java (original)
> +++ james/protocols/imap/trunk/seda/src/main/java/org/apache/james/experimental/imapserver/ImapHandlerConfigurationData.java Mon Sep 15 12:51:10 2008
> @@ -27,6 +27,7 @@
>  /**
>   * Provides a number of server-wide constant values to the
>   * POP3Handlers
> + * @deprecated unnecessary
>   */
>  public interface ImapHandlerConfigurationData
>  {

I just noticed the javadoc is about POP3.

Stefano

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org