[GitHub] [superset] ktmud commented on a change in pull request #13057: feat: Add sort by metric for pivot-table

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r574169126



##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
             raise QueryObjectValidationError(_("Please choose at least one metric"))
         if set(groupby) & set(columns):
             raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+        sort_by = self.form_data.get("timeseries_limit_metric")

Review comment:
       I think this is just from legacy form_data field names. We'd need a db migration if we want to rename it.
   
   Superset has a timeseries-first UI. Each pivot group can be considered a series since the base query has the ability to aggregate by time + pivot column.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org