You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/03/01 19:31:25 UTC

[GitHub] [couchdb] bessbd opened a new pull request #3390: Make session elixir test more robust

bessbd opened a new pull request #3390:
URL: https://github.com/apache/couchdb/pull/3390


   ## Overview
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   Depending on the situation, the session context may have elements other than `_admin`. This PR relaxes the check to make the test case more robust.
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd merged pull request #3390: Make session elixir test more robust

Posted by GitBox <gi...@apache.org>.
bessbd merged pull request #3390:
URL: https://github.com/apache/couchdb/pull/3390


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd commented on pull request #3390: Make session elixir test more robust

Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3390:
URL: https://github.com/apache/couchdb/pull/3390#issuecomment-788229495


   Thank you for the review, @iilyak ! I'm about to merge this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org