[jira] Commented: (FELIX-586) org.apache.felix.webconsole.internal.compendium.BaseConfigManager.getAttributeDefinitionMap(): implementation does not properly handle Configuration instances of a ManagedServiceFactory

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604811#action_12604811 ] 

Felix Meschberger commented on FELIX-586:
-----------------------------------------

With my patch [1] attached to FELIX-587, this issue should also be solved as for a configuration with factory PID only the factory PID would be considered.

WDYT ?

[1] https://issues.apache.org/jira/secure/attachment/12383956/FELIX-587-fmeschbe.patch

> org.apache.felix.webconsole.internal.compendium.BaseConfigManager.getAttributeDefinitionMap(): implementation does not properly handle Configuration instances of a ManagedServiceFactory
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-586
>                 URL: https://issues.apache.org/jira/browse/FELIX-586
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>            Reporter: Dieter Wimberger
>         Attachments: ConfigManagerBase.java.diff
>
>
> The implementation of org.apache.felix.webconsole.internal.compendium.BaseConfigManager.getAttributeDefinitionMap(): does not properly handle Configuration instances of a ManagedServiceFactory.
> In fact, if such a Configuration instance is passed in as a parameter, the method will throw an exception, because there is no ObjectClassDefinition available for the instance.
> Example:
> A Configuration instance for the ManagedServiceFactory "net.wimpi.telnetd.service.TelnetListenerServiceFactory" was created through the ConfigurationAdmin that assigned the pid "net.wimpi.telnetd.service.TelnetListenerServiceFactory-1212198114040-7". Given that the method will try to obtain an ObjectClassDefinition for "net.wimpi.telnetd.service.TelnetListenerServiceFactory-1212198114040-7", an exception will be thrown, because no such OCD is available.
> Fix:
> The method needs to check if the Configuration instance has a factoryPid assigned, and should use the factoryPid to obtain the  ObjectClassDefinition corresponding to the ManagedServiceFactory.
> Also observed in revision 662145 SVN repository.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.