You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/25 20:29:46 UTC
[GitHub] [incubator-superset] etr2460 commented on a change in pull request
#9350: [dashboard] handle markdown error
etr2460 commented on a change in pull request #9350: [dashboard] handle markdown error
URL: https://github.com/apache/incubator-superset/pull/9350#discussion_r398147585
##########
File path: superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx
##########
@@ -73,6 +77,8 @@ const markdownPlaceHolder = `# ✨Markdown
Click here to edit [markdown](https://bit.ly/1dQOfRK)`;
+const emergencyCode = t('This markdown component has an error.');
Review comment:
I'd name this `errorMessage` instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org