You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org> on 2018/10/01 17:38:29 UTC

[Impala-ASF-CR] Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"

Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11551


Change subject: Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"
......................................................................

Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"

Breaks downstream dependence on profile (1/2 of changes).

This reverts commit 235748316c5cada5c58b3e84a4e20ee57f1c4a49.

Change-Id: I80b4c0e4b8487572285ac788ab0195896f221842
---
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_pull_stats.py
3 files changed, 3 insertions(+), 93 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/11551/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80b4c0e4b8487572285ac788ab0195896f221842
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>

[Impala-ASF-CR] Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11551 )

Change subject: Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b4c0e4b8487572285ac788ab0195896f221842
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Oct 2018 17:52:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11551 )

Change subject: Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"
......................................................................

Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"

Breaks downstream dependence on profile (1/2 of changes).

This reverts commit 235748316c5cada5c58b3e84a4e20ee57f1c4a49.

Change-Id: I80b4c0e4b8487572285ac788ab0195896f221842
Reviewed-on: http://gerrit.cloudera.org:8080/11551
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_pull_stats.py
3 files changed, 3 insertions(+), 93 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I80b4c0e4b8487572285ac788ab0195896f221842
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 3
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11551 )

Change subject: Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b4c0e4b8487572285ac788ab0195896f221842
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Oct 2018 21:33:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11551 )

Change subject: Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3252/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b4c0e4b8487572285ac788ab0195896f221842
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Oct 2018 17:52:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11551 )

Change subject: Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b4c0e4b8487572285ac788ab0195896f221842
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Oct 2018 17:49:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11551 )

Change subject: Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/878/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80b4c0e4b8487572285ac788ab0195896f221842
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Oct 2018 18:12:07 +0000
Gerrit-HasComments: No