[jira] [Comment Edited] (FLINK-26484) FileSystem.delete is not implemented consistently

["Matthias Pohl (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-26484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501213#comment-17501213 ] 

Matthias Pohl edited comment on FLINK-26484 at 3/4/22, 8:20 AM:
----------------------------------------------------------------

We should implement the recursive deletion in {{FileSystem}} and only rely on {{FileSystem.deleteFile(path)}} (which is a replacement for {{FileSystem.delete(path, false)}}), {{FileSystem.exists(path)}}, and {{FileSystem.listStatuses(path)}}. We can remove redundant code in {{LocalFileSystem}} as well due to that.

{{LocalFileSystem}} and {{HadoopFileSystem}} are the only implementations that don't delegate to another {{FileSystem}} implementation internally.


was (Author: mapohl):
We should implement the recursive deletion in {{FileSystem}} and only rely on {{FileSystem.deleteFile(path)}} (which is a replacement for {{FileSystem.delete(path, false)}}), {{FileSystem.exists(path)}}, and {{FileSystem.listStatuses(path)}}. We can remove redundant code in {{LocalFileSystem}} as well due to that.

> FileSystem.delete is not implemented consistently
> -------------------------------------------------
>
>                 Key: FLINK-26484
>                 URL: https://issues.apache.org/jira/browse/FLINK-26484
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / FileSystem, Runtime / Coordination
>    Affects Versions: 1.15.0
>            Reporter: Matthias Pohl
>            Priority: Critical
>
> The BlobServer cleanup does not work for the Presto S3 filesystem in case of failure due to some bug in the recursive delete implementation. The {{false}} return value is not processed which leads to an error case being "swallowed", i.e. recursive cleanups do not work in this case (see [PrestoS3FileSystem:496|https://github.com/prestodb/presto/blob/master/presto-hive/src/main/java/com/facebook/presto/hive/s3/PrestoS3FileSystem.java#L496])



--
This message was sent by Atlassian Jira
(v8.20.1#820001)