You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2016/11/17 16:04:15 UTC
wicket git commit: WICKET-6278 no functional change
Repository: wicket
Updated Branches:
refs/heads/master 4b600a200 -> 51b934007
WICKET-6278 no functional change
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/51b93400
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/51b93400
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/51b93400
Branch: refs/heads/master
Commit: 51b934007a19a51bcb8e56d3c28101dd5f92e6db
Parents: 4b600a2
Author: Sven Meier <sv...@apache.org>
Authored: Thu Nov 17 16:54:09 2016 +0100
Committer: Sven Meier <sv...@apache.org>
Committed: Thu Nov 17 16:54:09 2016 +0100
----------------------------------------------------------------------
.../java/org/apache/wicket/util/tester/TagTester.java | 2 ++
.../org/apache/wicket/util/tester/TagTesterTest.java | 12 +++++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/51b93400/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java b/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
index 610b181..ca851ae 100644
--- a/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
+++ b/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
@@ -399,6 +399,8 @@ public class TagTester
* the markup to look for the tag to create the <code>TagTester</code> from the value
* which the attribute must have
* @return the <code>TagTester</code> which matches the tag by name in the markup
+ *
+ * @deprecated use {@link #createTagByName(String, String)} instead
*/
@Deprecated
public static TagTester createTagByAttribute(String markup, String tagName)
http://git-wip-us.apache.org/repos/asf/wicket/blob/51b93400/wicket-core/src/test/java/org/apache/wicket/util/tester/TagTesterTest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/util/tester/TagTesterTest.java b/wicket-core/src/test/java/org/apache/wicket/util/tester/TagTesterTest.java
index f992310..d4fe36e 100644
--- a/wicket-core/src/test/java/org/apache/wicket/util/tester/TagTesterTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/util/tester/TagTesterTest.java
@@ -39,7 +39,17 @@ public class TagTesterTest extends Assert
"<ajax-response><component id='comp1'><![CDATA[<div class='cls' id='compId'></div>]]></component></ajax-response>";
// WICKET-5874
- private static final String NON_CLOSED_INPUT = "<p><input wicket:id=\"wicketId\" type=\"text\"></p>";
+ private static final String NON_CLOSED_INPUT = "<p wicket:id=\"p\"><input wicket:id=\"wicketId\" type=\"text\"></p>";
+
+ /**
+ * WICKET-6278
+ */
+ @Test
+ public void tagNoRequiredClose() {
+ TagTester tester = TagTester.createTagByAttribute(NON_CLOSED_INPUT, "wicket:id", "p");
+
+ assertEquals("<input wicket:id=\"wicketId\" type=\"text\">", tester.getValue());
+ }
/**
* https://issues.apache.org/jira/browse/WICKET-5874