You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "jakezhu9 (via GitHub)" <gi...@apache.org> on 2023/03/09 09:05:54 UTC
[GitHub] [incubator-devlake] jakezhu9 opened a new pull request, #4625: feat: implement the trello plugin
jakezhu9 opened a new pull request, #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625
### Summary
implement the trello plugin
### Does this close any open issues?
Closes #1881
### Screenshots
### Other Information
This plugin collects data from the Trello API and transforms the raw data into the tool layer.
I didn't implement the task of converting the data to the domain layer because Trello is a flexible work management tool, and some fields cannot be converted to those in the issue with fixed rules, such as type and status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #4625: feat: implement the trello plugin
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1462201332
@jakezhu9 Great job! Thanks for your contribution, there are some issues from the CI, would you like to fix them first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mappjzc commented on pull request #4625: feat: implement the trello plugin
Posted by "mappjzc (via GitHub)" <gi...@apache.org>.
mappjzc commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1471983826
> @jakezhu9 @mappjzc I see, I think it would be better to use the `AppKey` instead of the `BasicAuth`. Note that we can modify the `req.Query` in the `SetupAuthentication` method as well to avoid confusion regarding which authorization method we opted for. Keep in mind we should add a document to https://devlake.apache.org/ at the end of the development to explain the authorization etc. Thanks for your hard work, appreciated it. 💪
Thanks for your help.
I had already succeeded to test your connection. It works.
And I try to run a blueprint for it, But here have some problems.
As you see, It sends out the error that "boardId is required".
This error comes from PrepareTaskData as follows.
It decodes from the map option to TrelloOptions.
And in TrelloOptions, It required BoardId with json field "boardId"
But in the blueprint, there is only filed "scopeId" in the JSON string.
To see the makePipelinePlanV200 of your code, you use the filed "scopeId" in the options JSON string.
Maybe you need to unify them in the way you like.
After I fixed this on my locally, this plugin can work successfully.
And another little thing. the CollectCheckItem and CollectChecklist Collect the same data.
It is enough only one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] jakezhu9 commented on pull request #4625: feat: implement the trello plugin
Posted by "jakezhu9 (via GitHub)" <gi...@apache.org>.
jakezhu9 commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1463510673
Hi @Startrekzky, I've joined Slack. Also, the CI errors has been fixed! I'm hoping this pr will help improve DevLake even further :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] jakezhu9 commented on pull request #4625: feat: implement the trello plugin
Posted by "jakezhu9 (via GitHub)" <gi...@apache.org>.
jakezhu9 commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1462204283
ok, I will fix them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] jakezhu9 commented on pull request #4625: feat: implement the trello plugin
Posted by "jakezhu9 (via GitHub)" <gi...@apache.org>.
jakezhu9 commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1474021672
Already fixed. There is an error about the commit message in ci, but it doesn't seem to be my reason, just ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mappjzc merged pull request #4625: feat: implement the trello plugin
Posted by "mappjzc (via GitHub)" <gi...@apache.org>.
mappjzc merged PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on pull request #4625: feat: implement the trello plugin
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1463093512
Hey @jakezhu9 , excellent work! We'll take a look at this PR. Are you in our community by the way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mappjzc commented on pull request #4625: feat: implement the trello plugin
Posted by "mappjzc (via GitHub)" <gi...@apache.org>.
mappjzc commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1466305491
> Hi @Startrekzky, I've joined Slack. Also, the CI errors have been fixed! I'm hoping this pr will help improve DevLake even further :)
Hi @jakezhu9 .I have tried to use your plugin but failed to test connection at first.
and I have checked the document of oauth.
It seems you don't use the full way for OAuth.
I can only get `Consumer Key` and `Consumer Secret`.
So I don't know how you config the connection to run it.
There are some codes from the document about how to use OAuth1.0 for Trello.
https://glitch.com/edit/#!/trello-oauth?path=server.js%3A37%3A0
Maybe It can help you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] jakezhu9 commented on pull request #4625: feat: implement the trello plugin
Posted by "jakezhu9 (via GitHub)" <gi...@apache.org>.
jakezhu9 commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1478838325
@mappjzc Absolutely! My WeChat ID is jakezhu9, and you can also reach me at [jakezhu9@gmail.com](mailto:jakezhu9@gmail.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] jakezhu9 commented on pull request #4625: feat: implement the trello plugin
Posted by "jakezhu9 (via GitHub)" <gi...@apache.org>.
jakezhu9 commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1467372312
Hi @mappjzc. You're absolutely right, I didn't fully implement oauth because it's a bit more complicated to set up.
Instead, I've been using a combination of an API key and token for authentication. You can find instructions for configuring this in the README and on the [Trello developer site](https://developer.atlassian.com/cloud/trello/guides/rest-api/api-introduction/).
One thing I should mention is that I haven't found a great way to store the API key and token in the plugin helper. Right now, I'm using helper.BasicAuth, which means you'll need to put the API key in the username field and the token in the password field. I know this isn't a good design and could cause some confusion.
If you have any suggestions for how to improve this, please let me know and I'll work on making it better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] jakezhu9 commented on pull request #4625: feat: implement the trello plugin
Posted by "jakezhu9 (via GitHub)" <gi...@apache.org>.
jakezhu9 commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1473075650
@mappjzc Thank you so much for reviewing my work carefully! I just realized that I made a mistake in the boardId and scopeId, but I'll get it fixed right away. I'm also working on adding `blueprint_test` to prevent similar issues from happening in the future.
As for CollectCheckItem and CollectChecklist, my original idea was to keep them separate since they are two different tasks. After giving it some thought, I agree with you that merging them into one task would be a better approach. I plan to keep only CheckItem and include the Checklist data within each item, as Checklist has only a few fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] jakezhu9 commented on pull request #4625: feat: implement the trello plugin
Posted by "jakezhu9 (via GitHub)" <gi...@apache.org>.
jakezhu9 commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1468232741
I have already switched to using the AppKey. I will add a document to explain the authorization process at the end of development. Thank you for your help and support, it is greatly appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #4625: feat: implement the trello plugin
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1467548124
@jakezhu9 @mappjzc I see, I think it would be better to use the `AppKey` instead of the `BasicAuth`.
Note that we can modify the `req.Query` in the `SetupAuthentication` method as well to avoid confusion regarding which authorization method we opted for.
Keep in mind we should add a document to https://devlake.apache.org/ at the end of the development to explain the authorization etc.
Thanks for your hard work, appreciated it. 💪
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mappjzc commented on pull request #4625: feat: implement the trello plugin
Posted by "mappjzc (via GitHub)" <gi...@apache.org>.
mappjzc commented on PR #4625:
URL: https://github.com/apache/incubator-devlake/pull/4625#issuecomment-1476601187
> Already fixed. There is an error about the commit message in ci, but it doesn't seem to be my reason, just ignore it.
@jakezhu9
Thank you so much.
It is a great pull request.
Can we have the privilege of obtaining more contact information about you for more convenient communication?
Like WeChat or others that you prefer to use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org