[GitHub] [flink] kougazhang commented on pull request #14362: [FLINK-20540] Failed connecting to jdbc:postgresql://flink-postgres

[GitBox <gi...@apache.org>]

kougazhang commented on pull request #14362:
URL: https://github.com/apache/flink/pull/14362#issuecomment-743114728


   > > Can we maybe change the code instead to handle this case more gracefully?
   > 
   > Thanks @zentol , that's a better way, I rechecked the code and found is problematic which should use the formatted `this.baseUrl` rather than the function parameter `baseUrl`:
   > 
   > ```
   > this.baseUrl = baseUrl.endsWith("/") ? baseUrl : baseUrl + "/";
   > this.defaultUrl = baseUrl + defaultDatabase; => this.defaultUrl = this.baseUrl + defaultDatabase; 
   > ```
   > 
   > And thus the document update is unnecessary and we should change the code and update the test or add a new test to cover the change.
   > @kougazhang HDYT?
   
   @leonardBang , I think your suggestion is very good, and I'll change the code as you suggest.
   When I found this bug, I wanted to change the code in this way. This is jira link: [Addr](https://issues.apache.org/jira/browse/FLINK-20540?focusedCommentId=17246236&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17246236)
   I am glad to see we have same idea.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org