You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apiri <gi...@git.apache.org> on 2017/09/14 16:20:54 UTC
[GitHub] nifi pull request #2155: NIFI-4193 Converting to use the dockerfile-maven pl...
GitHub user apiri opened a pull request:
https://github.com/apache/nifi/pull/2155
NIFI-4193 Converting to use the dockerfile-maven plugin
NIFI-4193 Converting to use the dockerfile-maven plugin to replace deprecated plugin.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/incubator-nifi nifi-4193
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2155
----
commit 7f8300f400c7d20c75970558397bf3d03d34873e
Author: Aldrin Piri <al...@apache.org>
Date: 2017-09-11T16:59:28Z
NIFI-4193 Converting to use the dockerfile-maven plugin to replace deprecated plugin.
----
---
[GitHub] nifi pull request #2155: NIFI-4193 Converting to use the dockerfile-maven pl...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2155#discussion_r153055354
--- Diff: nifi-docker/dockermaven/pom.xml ---
@@ -0,0 +1,82 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to
+ You under the Apache License, Version 2.0 (the "License"); you may not use
+ this file except in compliance with the License. You may obtain a copy of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-docker</artifactId>
+ <version>1.4.0-SNAPSHOT</version>
--- End diff --
@apiri Hey, your ${project.version} change was just overlaid on top of master so all the dockerfile-maven plugin changes are gone.
---
[GitHub] nifi issue #2155: NIFI-4193 Converting to use the dockerfile-maven plugin
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/2155
Reviewing for once
---
[GitHub] nifi issue #2155: NIFI-4193 Converting to use the dockerfile-maven plugin
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/2155
@jfrazee Indeed... you didn't happen to notice this before updating your pull did you? I seem to have completely lost it on my local repo (and I'm thinking I compounded issues by picking an untimely point to do a manual gc)
---
[GitHub] nifi issue #2155: NIFI-4193 Converting to use the dockerfile-maven plugin
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/2155
well, git reflog has saved me. will fix this up
---
[GitHub] nifi issue #2155: NIFI-4193 Converting to use the dockerfile-maven plugin
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/2155
okay, should actually have the material changes too! thanks for alerting me.
---
[GitHub] nifi pull request #2155: NIFI-4193 Converting to use the dockerfile-maven pl...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2155#discussion_r152643684
--- Diff: nifi-docker/dockermaven/pom.xml ---
@@ -0,0 +1,82 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to
+ You under the Apache License, Version 2.0 (the "License"); you may not use
+ this file except in compliance with the License. You may obtain a copy of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-docker</artifactId>
+ <version>1.4.0-SNAPSHOT</version>
--- End diff --
updated to use ${project.version}
---
[GitHub] nifi pull request #2155: NIFI-4193 Converting to use the dockerfile-maven pl...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2155#discussion_r152630562
--- Diff: nifi-docker/dockermaven/pom.xml ---
@@ -0,0 +1,82 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to
+ You under the Apache License, Version 2.0 (the "License"); you may not use
+ this file except in compliance with the License. You may obtain a copy of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-docker</artifactId>
+ <version>1.4.0-SNAPSHOT</version>
--- End diff --
Yep. This was originally submitted a couple months ago. Will update.
---
[GitHub] nifi pull request #2155: NIFI-4193 Converting to use the dockerfile-maven pl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2155
---
[GitHub] nifi pull request #2155: NIFI-4193 Converting to use the dockerfile-maven pl...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2155#discussion_r152583250
--- Diff: nifi-docker/dockermaven/pom.xml ---
@@ -0,0 +1,82 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to
+ You under the Apache License, Version 2.0 (the "License"); you may not use
+ this file except in compliance with the License. You may obtain a copy of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-docker</artifactId>
+ <version>1.4.0-SNAPSHOT</version>
--- End diff --
@apiri Shouldn't this be 1.5.0-SNAPSHOT now? The PR is into master and not a maint branch so wanted to check.
---
[GitHub] nifi issue #2155: NIFI-4193 Converting to use the dockerfile-maven plugin
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/2155
LGTM +1
Successfully ran build w/ -Pcontrib-check and tested image w/ `docker run -it -p 8080:8080 apache/nifi:latest`
---