You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/25 13:52:00 UTC
[GitHub] [incubator-kvrocks] tanruixiang opened a new pull request, #922: Fixed a bug where ip was used as port number.
tanruixiang opened a new pull request, #922:
URL: https://github.com/apache/incubator-kvrocks/pull/922
In the previous test, 127.0.0.1 has been resolved to port number 127 for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #922: fix: ip was used as port number.
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #922:
URL: https://github.com/apache/incubator-kvrocks/pull/922#issuecomment-1257519167
> @git-hulk @PragmaTwice Hi. Do you have time to review?
Yes, will take a look tonight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tanruixiang commented on pull request #922: fix: ip was used as port number.
Posted by GitBox <gi...@apache.org>.
tanruixiang commented on PR #922:
URL: https://github.com/apache/incubator-kvrocks/pull/922#issuecomment-1257520586
> Yes, will take a look tonight.
Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tanruixiang commented on pull request #922: fix: ip was used as port number.
Posted by GitBox <gi...@apache.org>.
tanruixiang commented on PR #922:
URL: https://github.com/apache/incubator-kvrocks/pull/922#issuecomment-1257518390
@git-hulk @PragmaTwice Hi. Do you have time to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #922: Fix uses the host as the port number in test case
Posted by GitBox <gi...@apache.org>.
git-hulk merged PR #922:
URL: https://github.com/apache/incubator-kvrocks/pull/922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tanruixiang commented on a diff in pull request #922: fix: ip was used as port number.
Posted by GitBox <gi...@apache.org>.
tanruixiang commented on code in PR #922:
URL: https://github.com/apache/incubator-kvrocks/pull/922#discussion_r979991360
##########
tests/tcl/tests/integration/slotmigrate.tcl:
##########
@@ -111,8 +111,8 @@ start_server {tags {"Src migration server"} overrides {cluster-enabled yes}} {
set node1_id "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx01"
$r1 clusterx setnodeid $node1_id
- set cluster_nodes "$node0_id 127.0.0.1 $node0_host master - 0-10000"
Review Comment:
Yes. `127.0.0.1` is used here as the port number, because atoi is parsed to 127. I will replace atoi with parseint in another pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] shangxiaoxiong commented on a diff in pull request #922: fix: ip was used as port number.
Posted by GitBox <gi...@apache.org>.
shangxiaoxiong commented on code in PR #922:
URL: https://github.com/apache/incubator-kvrocks/pull/922#discussion_r979596008
##########
tests/tcl/tests/integration/slotmigrate.tcl:
##########
@@ -111,8 +111,8 @@ start_server {tags {"Src migration server"} overrides {cluster-enabled yes}} {
set node1_id "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx01"
$r1 clusterx setnodeid $node1_id
- set cluster_nodes "$node0_id 127.0.0.1 $node0_host master - 0-10000"
Review Comment:
Here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org