[GitHub] [arrow-rs] alamb commented on a change in pull request #418: Fix bug with null buffer offset in boolean not kernel

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #418:
URL: https://github.com/apache/arrow-rs/pull/418#discussion_r646683427



##########
File path: arrow/src/compute/kernels/boolean.rs
##########
@@ -813,6 +813,19 @@ mod tests {
         assert_eq!(c, expected);
     }
 
+    #[test]
+    fn test_bool_array_not_sliced() {

Review comment:
       For anyone interested, without the code change this test fails in the following way:
   
   ```
   
   ---- compute::kernels::boolean::tests::test_bool_array_not_sliced stdout ----
   thread 'compute::kernels::boolean::tests::test_bool_array_not_sliced' panicked at 'assertion failed: ceil(offset + len, 8) <= buffer.len() * 8', arrow/src/util/bit_chunk_iterator.rs:33:9
   
   
   failures:
       compute::kernels::boolean::tests::test_bool_array_not_sliced
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org