You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GayathriMurali <gi...@git.apache.org> on 2015/09/07 22:08:45 UTC

[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

GitHub user GayathriMurali opened a pull request:

    https://github.com/apache/spark/pull/8647

    [SPARK-10380] - Confusing examples in pyspark SQL docs

    Made documentation changes to Pyspark sql module. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GayathriMurali/spark SPARK-10380

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/8647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8647
    
----
commit d5af89624edc74d5dca5b63ca8d1f76a5a300308
Author: Gayathri Murali <ga...@gmail.com>
Date:   2015-09-07T19:57:05Z

    [SPARK-10380] - Confusing examples in pyspark SQL docs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8647#discussion_r47686635
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -329,6 +329,8 @@ def cast(self, dataType):
             [Row(ages=u'2'), Row(ages=u'5')]
             >>> df.select(df.age.cast(StringType()).alias('ages')).collect()
             [Row(ages=u'2'), Row(ages=u'5')]
    +        
    +	(Note : cast is alias for astype)
    --- End diff --
    
    indent 1 more?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8647#discussion_r38949687
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -329,6 +329,8 @@ def cast(self, dataType):
             [Row(ages=u'2'), Row(ages=u'5')]
             >>> df.select(df.age.cast(StringType()).alias('ages')).collect()
             [Row(ages=u'2'), Row(ages=u'5')]
    +        
    +	(Note : astype is alias for cast)
    --- End diff --
    
    The problem that I was referring to is exactly that the documentation is repeated instead of being adapted for the function that is described.  The code examples for `astype` should use `astype` not `cast`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-138369576
  
    There are several points mentioned in the JIRA; this is just one of them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-192776038
  
    @andrewor14 Closing this PR as it is long due. Opening a new PR with all the changes made


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-138757596
  
    Recent commit contains all 4 methods(cast, astype, dropDuplicates and drop_duplicates) added and changes to docs as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-138369567
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali closed the pull request at:

    https://github.com/apache/spark/pull/8647


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-164870848
  
    @davies @GayathriMurali any updates on this? Is this patch still active?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8647#discussion_r38910982
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -329,6 +329,8 @@ def cast(self, dataType):
             [Row(ages=u'2'), Row(ages=u'5')]
             >>> df.select(df.age.cast(StringType()).alias('ages')).collect()
             [Row(ages=u'2'), Row(ages=u'5')]
    +        
    +	(Note : astype is alias for cast)
    --- End diff --
    
    I think @marmbrus also suggested that cast docs be updated to note the alias the other way -- there may be two more changes to make.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-138370526
  
    Pull request modified : Added both documentation changes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-139443510
  
    @GayathriMurali I meant we should keep the docstring, but don't need to copy the implementation.
    
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8647#discussion_r39213684
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -341,7 +343,30 @@ def cast(self, dataType):
                 raise TypeError("unexpected type: %s" % type(dataType))
             return Column(jc)
     
    -    astype = cast
    +    @ignore_unicode_prefix
    +    @since(1.3)
    +    def astype(self, dataType):
    +        """ Convert the column into type ``dataType``.
    +
    +        >>> df.select(df.age.astype("string").alias('ages')).collect()
    +        [Row(ages=u'2'), Row(ages=u'5')]
    +        >>> df.select(df.age.astype(StringType()).alias('ages')).collect()
    +        [Row(ages=u'2'), Row(ages=u'5')]
    +
    +        (Note : astype is alias for cast)
    +        """
    +        if isinstance(dataType, basestring):
    +            jc = self._jc.astype(dataType)
    +        elif isinstance(dataType, DataType):
    +            sc = SparkContext._active_spark_context
    +            ssql_ctx = sc._jvm.SQLContext(sc._jsc.sc())
    +            jdt = ssql_ctx.parseDataType(dataType.json())
    +            jc = self._jc.astype(jdt)
    +        else:
    +            raise TypeError("unexpected type: %s" % type(dataType))
    +        return Column(jc)
    +
    +    # astype = cast
    --- End diff --
    
    remove this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-144185894
  
      [Test build #1828 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1828/console) for   PR 8647 at commit [`a172d96`](https://github.com/apache/spark/commit/a172d96f00e559a2c0ec0fa44ea67bce2f89cd28).
     * This patch **fails Python style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8647#discussion_r47686610
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -943,13 +969,48 @@ def dropDuplicates(self, subset=None):
             +---+------+-----+
             |  5|    80|Alice|
             +---+------+-----+
    -        """
    +        
    +	(Note: dropDuplicates is an alias for drop_duplicates)
    +	"""
    --- End diff --
    
    indentation is off?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8647#discussion_r39213746
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -341,7 +343,30 @@ def cast(self, dataType):
                 raise TypeError("unexpected type: %s" % type(dataType))
             return Column(jc)
     
    -    astype = cast
    +    @ignore_unicode_prefix
    +    @since(1.3)
    +    def astype(self, dataType):
    +        """ Convert the column into type ``dataType``.
    +
    +        >>> df.select(df.age.astype("string").alias('ages')).collect()
    +        [Row(ages=u'2'), Row(ages=u'5')]
    +        >>> df.select(df.age.astype(StringType()).alias('ages')).collect()
    +        [Row(ages=u'2'), Row(ages=u'5')]
    +
    +        (Note : astype is alias for cast)
    +        """
    +        if isinstance(dataType, basestring):
    --- End diff --
    
    We can just call `self.cast(dataType)` here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8647#discussion_r39213831
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -1275,7 +1310,7 @@ def toPandas(self):
         ##########################################################################################
     
         groupby = groupBy
    --- End diff --
    
    Could you also do this for groupby ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-140552289
  
    Removed astype implementation added self.cast(dataType) return. Made similar changes to groupby as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8647#discussion_r38950029
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -329,6 +329,8 @@ def cast(self, dataType):
             [Row(ages=u'2'), Row(ages=u'5')]
             >>> df.select(df.age.cast(StringType()).alias('ages')).collect()
             [Row(ages=u'2'), Row(ages=u'5')]
    +        
    +	(Note : astype is alias for cast)
    --- End diff --
    
    Got it. I was skeptical about the code change. I will make it now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by asokadiggs <gi...@git.apache.org>.
Github user asokadiggs commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-144508693
  
    I've encountered the same problem @GayathriMurali been looking at here and separately reported and fixed it in [SPARK-10782].  There, the specific issue is that drop_duplicates doesn't exist as an independent method definition - around line 1280-1285 of dataframe.py you'll find "drop_duplicates = dropDuplicates" for the method definition.  So there is no separate documentation string for drop_duplicates.
    
    I "fixed" that problem by adding to the dropDuplicates documentation the note that drop_duplicates is an alias for dropDuplicates, with the presumption that the reader can substitute drop_duplicates in the code example for dropDuplicates on their own.
    
    That works for a few instances, but I'm thinking it's pointing to a larger issue that may warrant a different approach.
    
    In the case of dropDuplicates and drop_duplicates, there is also the method distinct.  All three do the same thing, but distinct is NOT implemented as an alias of dropDuplicates.  So we have 2 implementations for 3 methods, all intended to do 1 thing (remove duplicate rows from a dataframe).  That doesn't sound healthy to me.
    
    Another issue with the aliasing approach currently being used is that the "@since" property is attached to the single method definition.  So if we were to alias distinct to dropDuplicates for 1.6.0, the documentation would indicate distinct has existed since 1.4.0 (rather than either the 1.3.0 when it was actually created, or the 1.6.0 when it was aliased to dropDuplicates).
    
    
    End result - this is a bit of documentation and code structure that I'm interested in helping out with, but I lack the skills or background to carry this myself.  @GayathriMurali - I am interested in assisting if you are still working this.  I have some thoughts about larger design intent that can guide individual fixes for different methods - what is the best forum for documenting and discussing these?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-139437463
  
    I am not sure if I understand what should be removed. Do you want me to remove the entire astype function that was added? Also where should I use the self.cast(dataType)? If its within astype definition, then the whole point to demonstrate the usage of astype is lost. Am I missing something here? I am sorry if this is something trivial and I am not seeing it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/8647#issuecomment-144185786
  
      [Test build #1828 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1828/consoleFull) for   PR 8647 at commit [`a172d96`](https://github.com/apache/spark/commit/a172d96f00e559a2c0ec0fa44ea67bce2f89cd28).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-10380] - Confusing examples in pyspark ...

Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8647#discussion_r38949240
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -329,6 +329,8 @@ def cast(self, dataType):
             [Row(ages=u'2'), Row(ages=u'5')]
             >>> df.select(df.age.cast(StringType()).alias('ages')).collect()
             [Row(ages=u'2'), Row(ages=u'5')]
    +        
    +	(Note : astype is alias for cast)
    --- End diff --
    
    I built and checked the html page. The note appears in both places. Its an alias and the inline documentation is repeated in both places. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org