You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2015/06/03 20:13:21 UTC

Review Request 35019: SENTRY-752 Sentry service audit log file name format should be consistent

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35019/
-----------------------------------------------------------

Review request for sentry, Colin Ma and Sravya Tirukkovalur.


Bugs: SENTRY-752
    https://issues.apache.org/jira/browse/SENTRY-752


Repository: sentry


Description
-------

Create the log file as fileName.timestamp. Remove the code to rename the file on rollover


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java edbd160 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/appender/TestRollingFileWithoutDeleteAppender.java 15393da 

Diff: https://reviews.apache.org/r/35019/diff/


Testing
-------

Added new testcase


Thanks,

Prasad Mujumdar


Re: Review Request 35019: SENTRY-752 Sentry service audit log file name format should be consistent

Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35019/#review86455
-----------------------------------------------------------

Ship it!


Ship It!

- Sravya Tirukkovalur


On June 3, 2015, 6:13 p.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35019/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 6:13 p.m.)
> 
> 
> Review request for sentry, Colin Ma and Sravya Tirukkovalur.
> 
> 
> Bugs: SENTRY-752
>     https://issues.apache.org/jira/browse/SENTRY-752
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Create the log file as fileName.timestamp. Remove the code to rename the file on rollover
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java edbd160 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/appender/TestRollingFileWithoutDeleteAppender.java 15393da 
> 
> Diff: https://reviews.apache.org/r/35019/diff/
> 
> 
> Testing
> -------
> 
> Added new testcase
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>