Re: Please help me generate a patch file

[Phil Steitz <ph...@steitz.com>]

Hi Sean,

In addition to line endings, two other things that sometimes cause 
problems are tabs vs. spaces and trailing spaces.  I can't remember if 
JBuilder has a "remove trailing spaces" edit option, but if it (or 
Tortoise CVS?) does and you have that turned on, that would cause the diff 
line below. The standard license template has a trailing space on the 
"changed" line. You should also make sure that your editor is set up to 
use spaces instead of tabs.

hth,

Phil

Sean Schofield wrote:
> Greetings,
> 
> I am trying to create a CVS patch.  I'm using JBuilder X and Tortoise CVS on 
> Windows XP.  As a test I modified a single existing line of code in JBuilder 
> and saved.  My format settings in JBuilder were set to "preserve current 
> line endings within files."  When I generate the patch file in CVS it 
> contains a ton of changes to lines that I did not change.
> 
> An example is the beginning of the patch file shows:
> 
> /*
> * Copyright 2002-2004 The Apache Software Foundation.
> - *
> + *
> 
> It would seem this might have something to do with the line breaks.  I have 
> tried RTFM as well as googling everywhere and cannot figure out what's going 
> on.  Please help!  I'd like to contribute something without my patch 
> screwing up the formatting, etc.of the source files.
> 
> Thanks,
> 
> sean 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org

Re: Please help me generate a patch file

[Sean Schofield <se...@schof.com>]

Phil,

Thanks for the info.  It turned out to be the trailing spaces.  In the 
JBuilder editor preferences there is an option to strip trailing whitespace 
when saving that is checked by default.  Perhaps someone could update the 
instructions for submitting a patch to include something about making sure 
your editor does not strip trailing whitespace.  It mentions not using tabs 
which I read and made sure not to do.

Anyways, thanks for the help.  I'm all set now.  Stay tuned for my patch!

sean


----- Original Message ----- 
From: "Phil Steitz" <ph...@steitz.com>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Saturday, September 11, 2004 8:45 AM
Subject: Re: Please help me generate a patch file


> Hi Sean,
>
> In addition to line endings, two other things that sometimes cause 
> problems are tabs vs. spaces and trailing spaces.  I can't remember if 
> JBuilder has a "remove trailing spaces" edit option, but if it (or 
> Tortoise CVS?) does and you have that turned on, that would cause the diff 
> line below. The standard license template has a trailing space on the 
> "changed" line. You should also make sure that your editor is set up to 
> use spaces instead of tabs.
>
> hth,
>
> Phil
>
> Sean Schofield wrote:
>> Greetings,
>>
>> I am trying to create a CVS patch.  I'm using JBuilder X and Tortoise CVS 
>> on Windows XP.  As a test I modified a single existing line of code in 
>> JBuilder and saved.  My format settings in JBuilder were set to "preserve 
>> current line endings within files."  When I generate the patch file in 
>> CVS it contains a ton of changes to lines that I did not change.
>>
>> An example is the beginning of the patch file shows:
>>
>> /*
>> * Copyright 2002-2004 The Apache Software Foundation.
>> - *
>> + *
>>
>> It would seem this might have something to do with the line breaks.  I 
>> have tried RTFM as well as googling everywhere and cannot figure out 
>> what's going on.  Please help!  I'd like to contribute something without 
>> my patch screwing up the formatting, etc.of the source files.
>>
>> Thanks,
>>
>> sean
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org