You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/14 18:47:51 UTC
[GitHub] [ozone] xiaoyuyao opened a new pull request #2333: HDDS-5344. Adding debug log for block token verification.
xiaoyuyao opened a new pull request #2333:
URL: https://github.com/apache/ozone/pull/2333
## What changes were proposed in this pull request?
Some of QE tests depend on the debug log to verify block token verification.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5344
## How was this patch tested?
Existing UT and QE test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2333: HDDS-5344. Adding debug log for block token verification.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2333:
URL: https://github.com/apache/ozone/pull/2333#discussion_r651207469
##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/token/BlockTokenVerifier.java
##########
@@ -76,6 +80,10 @@ protected Object getService(ContainerCommandRequestProtoOrBuilder cmd) {
@Override
protected void verify(OzoneBlockTokenIdentifier tokenId,
ContainerCommandRequestProtoOrBuilder cmd) throws SCMSecurityException {
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Verifying token:{} for user:{} ", tokenId,
+ tokenId.getUser());
Review comment:
Previously this message was logged after reading the token (before verifying signer cert, etc.) Is this difference OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2333: HDDS-5344. Adding debug log for block token verification.
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #2333:
URL: https://github.com/apache/ozone/pull/2333#discussion_r651237646
##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/token/BlockTokenVerifier.java
##########
@@ -76,6 +80,10 @@ protected Object getService(ContainerCommandRequestProtoOrBuilder cmd) {
@Override
protected void verify(OzoneBlockTokenIdentifier tokenId,
ContainerCommandRequestProtoOrBuilder cmd) throws SCMSecurityException {
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Verifying token:{} for user:{} ", tokenId,
+ tokenId.getUser());
Review comment:
Thanks for the review, @adoroszlai. I think the difference should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org