You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Felix Knecht <fe...@apache.org> on 2007/07/18 18:16:10 UTC
Re: svn commit: r556438 - in /cocoon/trunk/core: cocoon-core/src/main/resources/META-INF/cocoon/avalon/
cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/
cocoon-pipeline/cocoon-pipeline-components/src/main/resources/MET...
danielf@apache.org schrieb:
> Modified: cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/FileGenerator.java
> URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/FileGenerator.java?view=diff&rev=556438&r1=556437&r2=556438
> ==============================================================================
> --- cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/FileGenerator.java (original)
> +++ cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/FileGenerator.java Sun Jul 15 12:31:31 2007
>
<snip>
>
> @@ -70,12 +98,19 @@
> throws ProcessingException, SAXException, IOException {
> super.setup(resolver, objectModel, src, par);
> try {
> + // Lookup parser in Avalon contexts
> + if (null == this.parser)
> + this.parser = (SAXParser) this.manager.lookup(SAXParser.class.getName());
> + } catch (ServiceException e) {
> + throw new ProcessingException("Exception when getting parser.", e);
> + }
> + try {
> this.inputSource = super.resolver.resolveURI(src);
> } catch (SourceException se) {
> throw SourceUtil.handle("Error during resolving of '" + src + "'.", se);
> }
> if (getLogger().isDebugEnabled()) {
> - getLogger().debug("Source " + super.source +
> + getLogger().error("Source " + super.source +
> " resolved to " + this.inputSource.getURI());
>
Sorry, but I do not understand why this needs to be logged to error?
Felix
Re: svn commit: r556438 - in /cocoon/trunk/core: cocoon-core/src/main/resources/META-INF/cocoon/avalon/
cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/
cocoon-pipeline/cocoon-pipeline-components/src/main/resources/MET...
Posted by Daniel Fagerstrom <da...@nada.kth.se>.
Felix Knecht skrev:
> danielf@apache.org schrieb:
>> Modified: cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/FileGenerator.java
>> URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/FileGenerator.java?view=diff&rev=556438&r1=556437&r2=556438
>> ==============================================================================
>> --- cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/FileGenerator.java (original)
>> +++ cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/FileGenerator.java Sun Jul 15 12:31:31 2007
>>
> <snip>
>>
>> @@ -70,12 +98,19 @@
>> throws ProcessingException, SAXException, IOException {
>> super.setup(resolver, objectModel, src, par);
>> try {
>> + // Lookup parser in Avalon contexts
>> + if (null == this.parser)
>> + this.parser = (SAXParser) this.manager.lookup(SAXParser.class.getName());
>> + } catch (ServiceException e) {
>> + throw new ProcessingException("Exception when getting parser.", e);
>> + }
>> + try {
>> this.inputSource = super.resolver.resolveURI(src);
>> } catch (SourceException se) {
>> throw SourceUtil.handle("Error during resolving of '" + src + "'.", se);
>> }
>> if (getLogger().isDebugEnabled()) {
>> - getLogger().debug("Source " + super.source +
>> + getLogger().error("Source " + super.source +
>> " resolved to " + this.inputSource.getURI());
>>
> Sorry, but I do not understand why this needs to be logged to error?
It was a mistake. I fixed it. Thanks for spotting it.
/Daniel
Re: svn commit: r556438 - in /cocoon/trunk/core: cocoon-core/src/main/resources/META-INF/cocoon/avalon/
cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/
cocoon-pipeline/cocoon-pipeline-components/src/main/resources/MET...
Posted by Felix Knecht <fe...@otego.com>.
Joerg Heinicke schrieb:
> On 18.07.2007 12:16, Felix Knecht wrote:
>
>>> if (getLogger().isDebugEnabled()) {
>>> - getLogger().debug("Source " + super.source +
>>> + getLogger().error("Source " + super.source +
>>> " resolved to " +
>>> this.inputSource.getURI());
>>>
>> Sorry, but I do not understand why this needs to be logged to error?
>
> Independent from the answer it will not log anyway if the log level is
> not at least debug because of isDebugEnabled().
I know this, but maybe I've could lerned something knew ;-). I'll fixed it.
>
> Joerg
>
Re: svn commit: r556438 - in /cocoon/trunk/core: cocoon-core/src/main/resources/META-INF/cocoon/avalon/
cocoon-pipeline/cocoon-pipeline-components/src/main/java/org/apache/cocoon/generation/
cocoon-pipeline/cocoon-pipeline-components/src/main/resources/MET...
Posted by Joerg Heinicke <jo...@gmx.de>.
On 18.07.2007 12:16, Felix Knecht wrote:
>> if (getLogger().isDebugEnabled()) {
>> - getLogger().debug("Source " + super.source +
>> + getLogger().error("Source " + super.source +
>> " resolved to " + this.inputSource.getURI());
>>
> Sorry, but I do not understand why this needs to be logged to error?
Independent from the answer it will not log anyway if the log level is
not at least debug because of isDebugEnabled().
Joerg