You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/02/14 19:33:29 UTC
[GitHub] [lucenenet] NightOwl888 opened a new pull request #620: PERFORMANCE: Lucene.Net.Index.BaseCompositeReader: Removed unnecessary list allocation
NightOwl888 opened a new pull request #620:
URL: https://github.com/apache/lucenenet/pull/620
Removed allocation of new `List<T>` that was added during the port to handle generic casting. Lucene [didn't have this extra allocation](https://github.com/apache/lucene/blob/releases/lucene-solr/4.8.0/lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java#L69).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] eladmarg commented on pull request #620: PERFORMANCE: Lucene.Net.Index.BaseCompositeReader: Removed unnecessary list allocation
Posted by GitBox <gi...@apache.org>.
eladmarg commented on pull request #620:
URL: https://github.com/apache/lucenenet/pull/620#issuecomment-1039505389
Great catch!
Any chance to push this to the upcoming release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 merged pull request #620: PERFORMANCE: Lucene.Net.Index.BaseCompositeReader: Removed unnecessary list allocation
Posted by GitBox <gi...@apache.org>.
NightOwl888 merged pull request #620:
URL: https://github.com/apache/lucenenet/pull/620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on pull request #620: PERFORMANCE: Lucene.Net.Index.BaseCompositeReader: Removed unnecessary list allocation
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on pull request #620:
URL: https://github.com/apache/lucenenet/pull/620#issuecomment-1040135685
> Great catch! Any chance to push this to the upcoming release?
Unfortunately, not. The binaries have already been built. But then, like any release there is always one more feature that would be nice to have. :point_up:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on pull request #620: PERFORMANCE: Lucene.Net.Index.BaseCompositeReader: Removed unnecessary list allocation
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on pull request #620:
URL: https://github.com/apache/lucenenet/pull/620#issuecomment-1040135685
> Great catch! Any chance to push this to the upcoming release?
Unfortunately, not. The binaries have already been built. But then, like any release there is always one more feature that would be nice to have. :point_up:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] eladmarg commented on pull request #620: PERFORMANCE: Lucene.Net.Index.BaseCompositeReader: Removed unnecessary list allocation
Posted by GitBox <gi...@apache.org>.
eladmarg commented on pull request #620:
URL: https://github.com/apache/lucenenet/pull/620#issuecomment-1039505389
Great catch!
Any chance to push this to the upcoming release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org