You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/09 16:20:32 UTC
[GitHub] [doris] yixiutt opened a new pull request, #14981: [bugfix](compaction) fix compaction trigger
yixiutt opened a new pull request, #14981:
URL: https://github.com/apache/doris/pull/14981
# Proposed changes
fix bug that when disable_auto_compaction=true but still trigger compaction
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14981: [bugfix](compaction) fix compaction trigger
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14981:
URL: https://github.com/apache/doris/pull/14981#issuecomment-1345446372
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14981: [bugfix](compaction) fix compaction trigger
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14981:
URL: https://github.com/apache/doris/pull/14981#issuecomment-1345242837
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14981: [bugfix](compaction) fix compaction trigger
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #14981:
URL: https://github.com/apache/doris/pull/14981#discussion_r1044618919
##########
be/src/olap/delta_writer.cpp:
##########
@@ -111,7 +111,8 @@ Status DeltaWriter::init() {
}
// check tablet version number
- if (_tablet->exceed_version_limit(config::max_tablet_version_num - 100)) {
+ if (!config::diable_auto_compaction &&
Review Comment:
warning: no member named 'diable_auto_compaction' in namespace 'doris::config'; did you mean 'disable_auto_compaction'? [clang-diagnostic-error]
```suggestion
if (!config::disable_auto_compaction &&
```
**be/src/common/config.h:252:** 'disable_auto_compaction' declared here
```cpp
CONF_mBool(disable_auto_compaction, "false");
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14981: [bugfix](compaction) fix compaction trigger
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14981:
URL: https://github.com/apache/doris/pull/14981#issuecomment-1344532675
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.56 seconds
load time: 428 seconds
storage size: 17123356022 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221209165228_clickbench_pr_61232.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14981: [bugfix](compaction) fix compaction trigger
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14981:
URL: https://github.com/apache/doris/pull/14981#issuecomment-1344516521
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #14981: [bugfix](compaction) fix compaction trigger
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #14981:
URL: https://github.com/apache/doris/pull/14981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14981: [bugfix](compaction) fix compaction trigger
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14981:
URL: https://github.com/apache/doris/pull/14981#issuecomment-1345242914
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14981: [bugfix](compaction) fix compaction trigger
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14981:
URL: https://github.com/apache/doris/pull/14981#issuecomment-1345446381
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org