You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Amogh Vasekar <am...@citrix.com> on 2013/07/17 02:11:42 UTC

Review Request 12611: Patch to fix stale cookie and refresh issue in UCS plugin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12611/
-----------------------------------------------------------

Review request for cloudstack, Animesh Chaturvedi and Frank Zhang.


Bugs: CLOUDSTACK-3426


Repository: cloudstack-git


Description
-------

Added a new class for storing UCS Cookie and associated timestamp.
getCookie() API changed to handle refresh and timeouts.
Timeouts are based on UCS server recommendation.


Diffs
-----

  plugins/hypervisors/ucs/src/com/cloud/ucs/manager/UcsCommands.java f6cc57f 
  plugins/hypervisors/ucs/src/com/cloud/ucs/manager/UcsManagerImpl.java 150e3dc 
  plugins/hypervisors/ucs/src/com/cloud/ucs/structure/UcsCookie.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12611/diff/


Testing
-------

Tested with UCS manager for APIs addUcsManager, listUcsProfile, listUcsBlade, associatesUcsProfileToBlade


Thanks,

Amogh Vasekar


Re: Review Request 12611: Patch to fix stale cookie and refresh issue in UCS plugin

Posted by Frank Zhang <fr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12611/#review23455
-----------------------------------------------------------

Ship it!


Ship It!

- Frank Zhang


On July 17, 2013, 12:11 a.m., Amogh Vasekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12611/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 12:11 a.m.)
> 
> 
> Review request for cloudstack, Animesh Chaturvedi and Frank Zhang.
> 
> 
> Bugs: CLOUDSTACK-3426
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added a new class for storing UCS Cookie and associated timestamp.
> getCookie() API changed to handle refresh and timeouts.
> Timeouts are based on UCS server recommendation.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/ucs/src/com/cloud/ucs/manager/UcsCommands.java f6cc57f 
>   plugins/hypervisors/ucs/src/com/cloud/ucs/manager/UcsManagerImpl.java 150e3dc 
>   plugins/hypervisors/ucs/src/com/cloud/ucs/structure/UcsCookie.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12611/diff/
> 
> 
> Testing
> -------
> 
> Tested with UCS manager for APIs addUcsManager, listUcsProfile, listUcsBlade, associatesUcsProfileToBlade
> 
> 
> Thanks,
> 
> Amogh Vasekar
> 
>