You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/13 20:29:36 UTC

[GitHub] [mynewt-core] dwld commented on issue #2233: Fix console echo handling

dwld commented on issue #2233: Fix console echo handling
URL: https://github.com/apache/mynewt-core/pull/2233#issuecomment-598898973
 
 
   > Hi @dwld could you please checked if this solution fixes problem that you detected?
   
   Hi @kasjer, thanks for your work. In my current project, I do not require NLIP. I just tested this PR with CONSOLE_ECHO: 0 and CONSOLE_NLIP: 0. Unfortunately, the new line is still there, since it is printed by lines 1168 and 1169 in console.c (`console_filter_out('\r');` and `console_filter_out('\n');`).
   
   Maybe we could add an option like your introduced CONSOLE_NLIP_ECHO_LF for NLIP to enable/disable (whatever is more reasonable) the new line echo in non-NLIP mode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services