You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/26 15:45:37 UTC

[GitHub] twalthr opened a new pull request #6534: [FLINK-10107] [sql-client] Relocate Flink Kafka connectors for SQL JARs

twalthr opened a new pull request #6534: [FLINK-10107] [sql-client] Relocate Flink Kafka connectors for SQL JARs
URL: https://github.com/apache/flink/pull/6534
 
 
   ## What is the purpose of the change
   
   This PR enforces even more shading for SQL JARs than before. In the past, we only shaded Kafka dependencies. However, since Flink's Kafka connectors mutually depend on each other and do not use version-specific package names (e.g. for Elasticsearch we use `elasticsearch2`, `elasticsearch3`, etc.). This is the only way of avoiding dependency conflicts between different Kafka SQL JARs. The end-to-end tests has been extended to detect classloading issues in builds.
   
   
   ## Brief change log
   
   - Add more relocation to Flink's Kafka SQL JARs
   
   
   ## Verifying this change
   
   SQL Client end-to-end tests has been adapted to detect classloading issues earlier.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes, but only for SQL JARs
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services