You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/17 05:25:20 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #4371: [License] Organize and modify the license of the code
morningman opened a new pull request #4371:
URL: https://github.com/apache/incubator-doris/pull/4371
1. Disable the MySQL client and LZO library by default when building the Doris.
MySQL client library is used for MySQL external table feature.
This feature will be replaced by the new ODBC external table soon.
LZO library is used to compress/decompress data of some old data format of Doris,
which is no longer used anymore.
2. Add missing license to some files.
3. For all non-Apache-License code, all are explained in NOTICE file and the corresponding license is declared.
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WillemJiang commented on a change in pull request #4371: [License] Organize and modify the license of the code
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on a change in pull request #4371:
URL: https://github.com/apache/incubator-doris/pull/4371#discussion_r474335521
##########
File path: build.sh
##########
@@ -140,6 +124,13 @@ if [ ${CLEAN} -eq 1 -a ${BUILD_BE} -eq 0 -a ${BUILD_FE} -eq 0 -a ${BUILD_SPARK_D
exit 1
fi
+if [[ -z ${WITH_MYSQL} ]]; then
Review comment:
Just a quick question how can we enable the build with MYSQL?
##########
File path: docs/en/README.md
##########
@@ -74,3 +74,23 @@ cases:
actionText: Quick Start →
actionLink: /en/installing/compilation
---
+
Review comment:
Do we need to add the License header on the markdown file?
##########
File path: docs/zh-CN/installing/compilation.md
##########
@@ -106,3 +106,22 @@ under the License.
```
编译完成后，产出文件在 `output/` 目录中。
+
+## 特别声明
+
+自 0.13 版本开始，默认的编译产出中将取消对 [1] 和 [2] 两个第三方库的依赖。这两个第三方库为 [GNU General Public License V3](https://www.gnu.org/licenses/gpl-3.0.en.html) 协议。该协议与 [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0) 协议不兼容，因此默认不出现在 Apache 发布版本中。
+
+依赖库 [1] 会导致无法访问 MySQL 外部表。访问 MySQL 外部表的功能会在后续版本中通过 UnixODBC 实现。
Review comment:
建议前面依赖库前面 加一个 “移除”。
##########
File path: docs/zh-CN/installing/compilation.md
##########
@@ -106,3 +106,22 @@ under the License.
```
编译完成后，产出文件在 `output/` 目录中。
+
+## 特别声明
+
+自 0.13 版本开始，默认的编译产出中将取消对 [1] 和 [2] 两个第三方库的依赖。这两个第三方库为 [GNU General Public License V3](https://www.gnu.org/licenses/gpl-3.0.en.html) 协议。该协议与 [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0) 协议不兼容，因此默认不出现在 Apache 发布版本中。
+
+依赖库 [1] 会导致无法访问 MySQL 外部表。访问 MySQL 外部表的功能会在后续版本中通过 UnixODBC 实现。
Review comment:
建议前面依赖库前面 加一个 “移除”。
还有就是依赖库[1] 应该是MySQL client吧！
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4371: [License] Organize and modify the license of the code
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4371:
URL: https://github.com/apache/incubator-doris/pull/4371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4371: [License] Organize and modify the license of the code
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4371:
URL: https://github.com/apache/incubator-doris/pull/4371#discussion_r474382172
##########
File path: build.sh
##########
@@ -140,6 +124,13 @@ if [ ${CLEAN} -eq 1 -a ${BUILD_BE} -eq 0 -a ${BUILD_FE} -eq 0 -a ${BUILD_SPARK_D
exit 1
fi
+if [[ -z ${WITH_MYSQL} ]]; then
Review comment:
Like this:
```
WITH_MYSQL=ON WIHT_LZO=ON sh build.sh
```
I had put it in the document of `compilation.md`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4371: [License] Organize and modify the license of the code
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4371:
URL: https://github.com/apache/incubator-doris/pull/4371#discussion_r474383396
##########
File path: docs/zh-CN/installing/compilation.md
##########
@@ -106,3 +106,22 @@ under the License.
```
编译完成后，产出文件在 `output/` 目录中。
+
+## 特别声明
+
+自 0.13 版本开始，默认的编译产出中将取消对 [1] 和 [2] 两个第三方库的依赖。这两个第三方库为 [GNU General Public License V3](https://www.gnu.org/licenses/gpl-3.0.en.html) 协议。该协议与 [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0) 协议不兼容，因此默认不出现在 Apache 发布版本中。
+
+依赖库 [1] 会导致无法访问 MySQL 外部表。访问 MySQL 外部表的功能会在后续版本中通过 UnixODBC 实现。
Review comment:
> 建议前面依赖库前面 加一个 “移除”。
好的
> 还有就是依赖库[1] 应该是MySQL client吧！
事实上，我们在第三方库中下载了完整的 MySQL 源码，其中包括 server 和 client 部分，但是我们只使用了其中的 client 部分。注释 [1] 中标注的 `mysql-5.7.18`，是在 `thirdparty/var.sh` 中写明的依赖名称，感觉两边一致的话，更便于用户查找。
##########
File path: docs/zh-CN/installing/compilation.md
##########
@@ -106,3 +106,22 @@ under the License.
```
编译完成后，产出文件在 `output/` 目录中。
+
+## 特别声明
+
+自 0.13 版本开始，默认的编译产出中将取消对 [1] 和 [2] 两个第三方库的依赖。这两个第三方库为 [GNU General Public License V3](https://www.gnu.org/licenses/gpl-3.0.en.html) 协议。该协议与 [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0) 协议不兼容，因此默认不出现在 Apache 发布版本中。
+
+依赖库 [1] 会导致无法访问 MySQL 外部表。访问 MySQL 外部表的功能会在后续版本中通过 UnixODBC 实现。
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4371: [License] Organize and modify the license of the code
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4371:
URL: https://github.com/apache/incubator-doris/pull/4371#discussion_r474388758
##########
File path: docs/en/README.md
##########
@@ -74,3 +74,23 @@ cases:
actionText: Quick Start →
actionLink: /en/installing/compilation
---
+
Review comment:
Oh, I can put the license in the `frontmatter` section. I will add it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4371: [License] Organize and modify the license of the code
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4371:
URL: https://github.com/apache/incubator-doris/pull/4371#discussion_r474381723
##########
File path: docs/en/README.md
##########
@@ -74,3 +74,23 @@ cases:
actionText: Quick Start →
actionLink: /en/installing/compilation
---
+
Review comment:
We have added a license header to all markdown files.
But this file is special and needs to be rendered as the homepage of the Doris website through `Vuepress`.
We have tried to add the license, but that will cause the rendering to fail.
Does this need to be specifically stated in the LICENSE file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org