You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2010/10/01 03:27:16 UTC
svn commit: r1003346 - in
/commons/proper/math/trunk/src/main/java/org/apache/commons/math: geometry/
linear/ optimization/direct/ optimization/linear/ random/
Author: sebb
Date: Fri Oct 1 01:27:16 2010
New Revision: 1003346
URL: http://svn.apache.org/viewvc?rev=1003346&view=rev
Log:
Make immutable private fields final
Modified:
commons/proper/math/trunk/src/main/java/org/apache/commons/math/geometry/Vector3DFormat.java
commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/OpenMapRealVector.java
commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealVectorFormat.java
commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/direct/PowellOptimizer.java
commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/linear/Relationship.java
commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/EmpiricalDistributionImpl.java
commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/RandomAdaptor.java
commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/ValueServer.java
Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/geometry/Vector3DFormat.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/geometry/Vector3DFormat.java?rev=1003346&r1=1003345&r2=1003346&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/geometry/Vector3DFormat.java (original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/geometry/Vector3DFormat.java Fri Oct 1 01:27:16 2010
@@ -73,7 +73,7 @@ public class Vector3DFormat extends Comp
private final String trimmedSeparator;
/** The format used for components. */
- private NumberFormat format;
+ private final NumberFormat format;
/**
* Create an instance with default settings.
Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/OpenMapRealVector.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/OpenMapRealVector.java?rev=1003346&r1=1003345&r2=1003346&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/OpenMapRealVector.java (original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/OpenMapRealVector.java Fri Oct 1 01:27:16 2010
@@ -44,7 +44,7 @@ public class OpenMapRealVector extends A
private final int virtualSize;
/** Tolerance for having a value considered zero. */
- private double epsilon;
+ private final double epsilon;
/**
* Build a 0-length vector.
Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealVectorFormat.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealVectorFormat.java?rev=1003346&r1=1003345&r2=1003346&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealVectorFormat.java (original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealVectorFormat.java Fri Oct 1 01:27:16 2010
@@ -76,7 +76,7 @@ public class RealVectorFormat extends Co
private final String trimmedSeparator;
/** The format used for components. */
- private NumberFormat format;
+ private final NumberFormat format;
/**
* Create an instance with default settings.
Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/direct/PowellOptimizer.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/direct/PowellOptimizer.java?rev=1003346&r1=1003345&r2=1003346&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/direct/PowellOptimizer.java (original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/direct/PowellOptimizer.java Fri Oct 1 01:27:16 2010
@@ -58,15 +58,15 @@ public class PowellOptimizer
/**
* Relative threshold.
*/
- private double relativeThreshold;
+ private final double relativeThreshold;
/**
* Absolute threshold.
*/
- private double absoluteThreshold;
+ private final double absoluteThreshold;
/**
* Line search.
*/
- private LineSearch line;
+ private final LineSearch line;
/**
* The arguments control the behaviour of the default convergence
Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/linear/Relationship.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/linear/Relationship.java?rev=1003346&r1=1003345&r2=1003346&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/linear/Relationship.java (original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/linear/Relationship.java Fri Oct 1 01:27:16 2010
@@ -34,7 +34,7 @@ public enum Relationship {
GEQ(">=");
/** Display string for the relationship. */
- private String stringValue;
+ private final String stringValue;
/** Simple constructor.
* @param stringValue display string for the relationship
Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/EmpiricalDistributionImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/EmpiricalDistributionImpl.java?rev=1003346&r1=1003345&r2=1003346&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/EmpiricalDistributionImpl.java (original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/EmpiricalDistributionImpl.java Fri Oct 1 01:27:16 2010
@@ -66,7 +66,7 @@ public class EmpiricalDistributionImpl i
private static final long serialVersionUID = 5729073523949762654L;
/** List of SummaryStatistics objects characterizing the bins */
- private List<SummaryStatistics> binStats = null;
+ private final List<SummaryStatistics> binStats;
/** Sample statistics */
private SummaryStatistics sampleStats = null;
@@ -81,7 +81,7 @@ public class EmpiricalDistributionImpl i
private double delta = 0d;
/** number of bins */
- private int binCount = 1000;
+ private final int binCount;
/** is the distribution loaded? */
private boolean loaded = false;
@@ -90,12 +90,13 @@ public class EmpiricalDistributionImpl i
private double[] upperBounds = null;
/** RandomData instance to use in repeated calls to getNext() */
- private RandomData randomData = new RandomDataImpl();
+ private final RandomData randomData = new RandomDataImpl();
/**
* Creates a new EmpiricalDistribution with the default bin count.
*/
public EmpiricalDistributionImpl() {
+ binCount = 1000;
binStats = new ArrayList<SummaryStatistics>();
}
Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/RandomAdaptor.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/RandomAdaptor.java?rev=1003346&r1=1003345&r2=1003346&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/RandomAdaptor.java (original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/RandomAdaptor.java Fri Oct 1 01:27:16 2010
@@ -31,13 +31,13 @@ public class RandomAdaptor extends Rando
private static final long serialVersionUID = 2306581345647615033L;
/** Wrapped randomGenerator instance */
- private RandomGenerator randomGenerator = null;
+ private final RandomGenerator randomGenerator;
/**
* Prevent instantiation without a generator argument
*/
@SuppressWarnings("unused")
- private RandomAdaptor() { }
+ private RandomAdaptor() { randomGenerator = null; }
/**
* Construct a RandomAdaptor wrapping the supplied RandomGenerator.
Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/ValueServer.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/ValueServer.java?rev=1003346&r1=1003345&r2=1003346&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/ValueServer.java (original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/random/ValueServer.java Fri Oct 1 01:27:16 2010
@@ -85,12 +85,13 @@ public class ValueServer {
private BufferedReader filePointer = null;
/** RandomDataImpl to use for random data generation. */
- private RandomData randomData = new RandomDataImpl();
+ private final RandomData randomData;
// Data generation modes ======================================
/** Creates new ValueServer */
public ValueServer() {
+ randomData = new RandomDataImpl();
}
/**