You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 13:52:00 UTC
[GitHub] [beam] damccorm opened a new issue, #19891: Update TestStreamPayload to use timestamp protos.
damccorm opened a new issue, #19891:
URL: https://github.com/apache/beam/issues/19891
Currently the timestamp fields are all int64, with no indication of whether the units are seconds, milliseconds, or microseconds.
https://github.com/apache/beam/blob/release-2.16.0/model/pipeline/src/main/proto/beam_runner_api.proto#L502
Imported from Jira [BEAM-8373](https://issues.apache.org/jira/browse/BEAM-8373). Original Jira may contain additional context.
Reported by: robertwb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update TestStreamPayload to use timestamp protos. [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on issue #19891:
URL: https://github.com/apache/beam/issues/19891#issuecomment-1863320132
Yep, looks like this can be closed - thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update TestStreamPayload to use timestamp protos. [beam]
Posted by "vineetg3 (via GitHub)" <gi...@apache.org>.
vineetg3 commented on issue #19891:
URL: https://github.com/apache/beam/issues/19891#issuecomment-1863251273
Hi @damccorm , the latest version seems to have a comment mentioning that the data type is inferred in milliseconds.
```
// Advances the watermark to the specified timestamp.
message AdvanceWatermark {
// (Required) The watermark in millisecond to advance to.
int64 new_watermark = 1;
// (Optional) The output watermark tag for a PCollection. If unspecified
// or with an empty string, this will default to the Main PCollection
// Output
string tag = 2;
}
```
Is this what this issue is expecting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update TestStreamPayload to use timestamp protos. [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed issue #19891: Update TestStreamPayload to use timestamp protos.
URL: https://github.com/apache/beam/issues/19891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org