You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/30 20:32:38 UTC

[GitHub] [airflow] mik-laj commented on pull request #9078: Don't create empty modules for plugins

mik-laj commented on pull request #9078:
URL: https://github.com/apache/airflow/pull/9078#issuecomment-636381764


   We create modules that do not contain any content. They are only added to sys.modules, but they cannot be used in any way. I care about it because it makes it difficult to understand the status of the plugins when you execute the [`airflow plugins` command](https://github.com/apache/airflow/pull/9001)
   
   Now when you run the following command 
   ```
   AIRFLOW__CORE__PLUGINS_FOLDER=$PWD/airflow/contrib/plugins/ airflow plugins
   ```
   you will see the output below.
   ```
   operators_modules = []
   sensors_modules = []
   hooks_modules = []
   macros_modules = []
   executors_modules = []
   ```
   Before
   ```
   operators_modules = [<module 'airflow.operators.metastore_browser'>]
   sensors_modules = [<module 'airflow.sensors.metastore_browser'>]
   hooks_modules = [<module 'airflow.hooks.metastore_browser'>]
   macros_modules = [<module 'airflow.macros.metastore_browser'>]
   executors_modules = [<module 'airflow.executors.metastore_browser'>]
   ```
   So thanks to this change you will be able to check which plugins affect which area of the application.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org