[GitHub] chewbranca commented on issue #746: Log additional information on crashes from rexi

[gi...@git.apache.org]

chewbranca commented on issue #746: Log additional information on crashes from rexi
URL: https://github.com/apache/couchdb/pull/746#issuecomment-321914459
 
 
   Overall I think this looks good, but I'm a bit confused as to why the nonce isn't getting logged already. We write the log entry in [1], which includes the `MsgId` in [2], and we set that value in [3] by way of [4]. This log statement is happening in `rexi_server:init_p/3` which is already recording the nonce [5], so I'm a bit confused as to why the nonce is not showing up as expected, or even the fall back msg_id [6].
   
   
   [1] https://github.com/apache/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/couch_log/src/couch_log_writer_syslog.erl#L76-L96
   [2] https://github.com/apache/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/couch_log/src/couch_log_writer_syslog.erl#L92
   [3] https://github.com/apache/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/couch_log/src/couch_log_formatter.erl#L44
   [4] https://github.com/apache/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/couch_log/src/couch_log_util.erl#L50
   [5] https://github.com/cloudant/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/rexi/src/rexi_server.erl#L138
   [6] https://github.com/cloudant/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/couch_log/src/couch_log_util.erl#L51
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services