You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/08/27 13:15:04 UTC
[GitHub] [carbondata] Indhumathi27 opened a new pull request #4211: [WIP][CARBONDATA-4273] Fix Cannot create external table with partitions
Indhumathi27 opened a new pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
### Is any new testcase added?
- No
- Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4211: [WIP][CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#issuecomment-907279017
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/302/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4211: [WIP][CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#issuecomment-907290884
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4157/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] akashrn5 commented on pull request #4211: [CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#issuecomment-909918089
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] akashrn5 commented on pull request #4211: [CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#issuecomment-909918089
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Lior-AI commented on a change in pull request #4211: [WIP][CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
Lior-AI commented on a change in pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#discussion_r698015433
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParserUtil.scala
##########
@@ -215,10 +215,6 @@ object CarbonSparkSqlParserUtil {
table.identifier.table.toLowerCase()
)
val tableInfo = if (isExternal) {
- if (partitionColumnNames.nonEmpty) {
Review comment:
Why can we remove it?
do we support this now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] akashrn5 commented on pull request #4211: [CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#issuecomment-908950128
@Indhumathi27 can you please add the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4211: [CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4211: [CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#issuecomment-909471428
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4161/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4211: [CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#issuecomment-909475345
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5905/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4211: [CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4211: [CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#issuecomment-909465962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] akashrn5 commented on pull request #4211: [CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#issuecomment-908950128
@Indhumathi27 can you please add the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4211: [CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#issuecomment-909465962
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/307/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4211: [WIP][CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#issuecomment-907283723
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5901/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4211: [WIP][CARBONDATA-4273] Fix Cannot create external table with partitions
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4211:
URL: https://github.com/apache/carbondata/pull/4211#discussion_r698294287
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParserUtil.scala
##########
@@ -215,10 +215,6 @@ object CarbonSparkSqlParserUtil {
table.identifier.table.toLowerCase()
)
val tableInfo = if (isExternal) {
- if (partitionColumnNames.nonEmpty) {
Review comment:
This scenario, already works fine in cluster. I have tested in Spark-Hadoop cluster. Local mode only uses this flow. So, better to keep same for all environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org