You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/08/01 10:12:50 UTC

[GitHub] [carbondata] Jeromestein opened a new pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Jeromestein opened a new pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192


   
    ### Why is this PR needed?
    Fixed the terrible heading level mistake of old version how-to-contribute-to-apache-carbondata.md. 
    
    ### What changes were proposed in this PR?
   1.  Fixed heading level mistake.
   2. Add TOC at the beginning.
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   JIRA Issue: https://issues.apache.org/jira/browse/CARBONDATA-4266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] Jeromestein commented on pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
Jeromestein commented on pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192#issuecomment-891065900


   @chenliang613  The TOC (table of content) works now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] chenliang613 commented on a change in pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
chenliang613 commented on a change in pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192#discussion_r680955858



##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -7,14 +7,16 @@
     the License.  You may obtain a copy of the License at
 
       http://www.apache.org/licenses/LICENSE-2.0
-
+    
     Unless required by applicable law or agreed to in writing, software 
     distributed under the License is distributed on an "AS IS" BASIS, 
     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
     See the License for the specific language governing permissions and 
     limitations under the License.
 -->
 
+[toc]

Review comment:
       Can you explain ,why add [toc] at here ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192#issuecomment-891166776


   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4066/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] chenliang613 commented on pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
chenliang613 commented on pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192#issuecomment-894627192


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] Jeromestein commented on a change in pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
Jeromestein commented on a change in pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192#discussion_r680983595



##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -55,35 +61,44 @@ For moderate or large contributions, you should not start coding or writing a de
 there is a corresponding JIRA issue assigned to you for that work. Simple changes,
 like fixing typos, do not require an associated issue.
 
-### Design
+
+
+
+
+## Design

Review comment:
       According to this line (No.29): "Engage -> Design -> Code -> Review -> Commit", the headings (Engage, Design, Code, Review) should be in same level, which is heading level 2. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] Jeromestein commented on a change in pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
Jeromestein commented on a change in pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192#discussion_r680980012



##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -7,14 +7,16 @@
     the License.  You may obtain a copy of the License at
 
       http://www.apache.org/licenses/LICENSE-2.0
-
+    
     Unless required by applicable law or agreed to in writing, software 
     distributed under the License is distributed on an "AS IS" BASIS, 
     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
     See the License for the specific language governing permissions and 
     limitations under the License.
 -->
 
+[toc]

Review comment:
       Try to add a **table of content** at the beginning of the doc, because It is a quite long documents and will be frequently queried for some specific part. It seems that it doesn't work in GitHub (while in my own interface it works well). 
   I will fix it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192#issuecomment-890490128


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] brijoobopanna commented on pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
brijoobopanna commented on pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192#issuecomment-891021862


   add to whitelist
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] asfgit closed pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] chenliang613 commented on a change in pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
chenliang613 commented on a change in pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192#discussion_r680956430



##########
File path: docs/how-to-contribute-to-apache-carbondata.md
##########
@@ -55,35 +61,44 @@ For moderate or large contributions, you should not start coding or writing a de
 there is a corresponding JIRA issue assigned to you for that work. Simple changes,
 like fixing typos, do not require an associated issue.
 
-### Design
+
+
+
+
+## Design

Review comment:
       why change Design with H2 header(markdown)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192#issuecomment-891161022


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5809/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4192: [CARBONDATA-4266][Doc][summer-2021] Add TOC and format how-to-contribute-to-apache-carbondata.md

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4192:
URL: https://github.com/apache/carbondata/pull/4192#issuecomment-891169187


   Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/214/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org