You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2021/08/04 09:27:18 UTC
[GitHub] [tomcat] rrodewald opened a new pull request #439: Minimal fixes to documentation of Context and Host
rrodewald opened a new pull request #439:
URL: https://github.com/apache/tomcat/pull/439
- Documented default value of unpackWARs attribute
- Tagged all boolean values als code
- Punctuation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on a change in pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #439:
URL: https://github.com/apache/tomcat/pull/439#discussion_r682466514
##########
File path: webapps/docs/config/host.xml
##########
@@ -302,7 +302,7 @@
placed in the <code>appBase</code> directory as web application
archive (WAR) files to be unpacked into a corresponding disk directory
structure, <code>false</code> to run such web applications directly
- from a WAR file. See
+ from a WAR file. The flag's value defaults to <code>true</code>. See
Review comment:
The default is...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rrodewald commented on pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
rrodewald commented on pull request #439:
URL: https://github.com/apache/tomcat/pull/439#issuecomment-893338812
If we want to standardize the wording for default values, I would suggest to open a new pull request for this, so that the main purpose of the present pull request (documentation of the default value of unpackWARs) can be considered as done.
Here is an incomplete list of wordings found:
- Defaults to ...
- Default [value] is ...
- The default [value] is ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] kkolinko commented on pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
kkolinko commented on pull request #439:
URL: https://github.com/apache/tomcat/pull/439#issuecomment-892610685
Reviewing...
1. context.xml L187 `s/docBase/<code>docBase</code>/ `as well
2. I am more used to "The default value is" rather than "The default is".
I wonder what wording is better. Tomcat documentation uses both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on a change in pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #439:
URL: https://github.com/apache/tomcat/pull/439#discussion_r682466514
##########
File path: webapps/docs/config/host.xml
##########
@@ -302,7 +302,7 @@
placed in the <code>appBase</code> directory as web application
archive (WAR) files to be unpacked into a corresponding disk directory
structure, <code>false</code> to run such web applications directly
- from a WAR file. See
+ from a WAR file. The flag's value defaults to <code>true</code>. See
Review comment:
The default is...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #439:
URL: https://github.com/apache/tomcat/pull/439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rrodewald commented on a change in pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
rrodewald commented on a change in pull request #439:
URL: https://github.com/apache/tomcat/pull/439#discussion_r682483565
##########
File path: webapps/docs/config/host.xml
##########
@@ -302,7 +302,7 @@
placed in the <code>appBase</code> directory as web application
archive (WAR) files to be unpacked into a corresponding disk directory
structure, <code>false</code> to run such web applications directly
- from a WAR file. See
+ from a WAR file. The flag's value defaults to <code>true</code>. See
Review comment:
Shall I change this for all other occurences of the same wording?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] kkolinko commented on pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
kkolinko commented on pull request #439:
URL: https://github.com/apache/tomcat/pull/439#issuecomment-892610685
Reviewing...
1. context.xml L187 `s/docBase/<code>docBase</code>/ `as well
2. I am more used to "The default value is" rather than "The default is".
I wonder what wording is better. Tomcat documentation uses both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rrodewald commented on pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
rrodewald commented on pull request #439:
URL: https://github.com/apache/tomcat/pull/439#issuecomment-892615291
> Reviewing...
>
> 1. context.xml L187 `s/docBase/<code>docBase</code>/ `as well
>
> 2. I am more used to "The default value is" rather than "The default is".
> I wonder what wording is better. Tomcat documentation uses both.
1. Done
2. I am no native speaker so I do whatever I'm told to do...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] ChristopherSchultz commented on pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
ChristopherSchultz commented on pull request #439:
URL: https://github.com/apache/tomcat/pull/439#issuecomment-893006283
To a native English speaker, either one is completely understandable.
"The default value is ___" is slightly more clear, but I would actually
defer to NON-native English speakers because it may be more
understandable to them one way or the other.
I'm happy to listen to the Russian :)
On 8/4/21 08:26, Robert Rodewald wrote:
> Reviewing...
>
> |1. context.xml L187 `s/docBase/<code>docBase</code>/ `as well 2. I
> am more used to "The default value is" rather than "The default is".
> I wonder what wording is better. Tomcat documentation uses both. |
>
> 1. Done
> 2. I am no native speaker so I do whatever I'm told to do...
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tomcat/pull/439#issuecomment-892615291>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AC5COWPV5U3WBTC4PVMQA3DT3EWXRANCNFSM5BQVO4NQ>.
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #439:
URL: https://github.com/apache/tomcat/pull/439#issuecomment-900239902
Thanks for the PR. +1 tp a new PR to make the default wording consistent.
Applied manually so I could a) add a change log entry and b) broadly maintain the line length limit of 80 chars for xml files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rrodewald commented on pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
rrodewald commented on pull request #439:
URL: https://github.com/apache/tomcat/pull/439#issuecomment-892615291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rrodewald commented on a change in pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
rrodewald commented on a change in pull request #439:
URL: https://github.com/apache/tomcat/pull/439#discussion_r682483565
##########
File path: webapps/docs/config/host.xml
##########
@@ -302,7 +302,7 @@
placed in the <code>appBase</code> directory as web application
archive (WAR) files to be unpacked into a corresponding disk directory
structure, <code>false</code> to run such web applications directly
- from a WAR file. See
+ from a WAR file. The flag's value defaults to <code>true</code>. See
Review comment:
Shall I change this for all other occurences of the same wording?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] ChristopherSchultz commented on pull request #439: Minimal fixes to documentation of Context and Host
Posted by GitBox <gi...@apache.org>.
ChristopherSchultz commented on pull request #439:
URL: https://github.com/apache/tomcat/pull/439#issuecomment-893006283
To a native English speaker, either one is completely understandable.
"The default value is ___" is slightly more clear, but I would actually
defer to NON-native English speakers because it may be more
understandable to them one way or the other.
I'm happy to listen to the Russian :)
On 8/4/21 08:26, Robert Rodewald wrote:
> Reviewing...
>
> |1. context.xml L187 `s/docBase/<code>docBase</code>/ `as well 2. I
> am more used to "The default value is" rather than "The default is".
> I wonder what wording is better. Tomcat documentation uses both. |
>
> 1. Done
> 2. I am no native speaker so I do whatever I'm told to do...
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tomcat/pull/439#issuecomment-892615291>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AC5COWPV5U3WBTC4PVMQA3DT3EWXRANCNFSM5BQVO4NQ>.
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org