You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/24 11:02:04 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing
cloud-fan commented on a change in pull request #33058:
URL: https://github.com/apache/spark/pull/33058#discussion_r657846088
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
##########
@@ -58,7 +58,11 @@ trait BroadcastExchangeLike extends Exchange {
* For registering callbacks on `relationFuture`.
* Note that calling this method may not start the execution of broadcast job.
*/
- def completionFuture: scala.concurrent.Future[broadcast.Broadcast[Any]]
+ final def completionFuture: scala.concurrent.Future[broadcast.Broadcast[Any]] = executeQuery {
Review comment:
This is kind of the AQE version of "execute", as AQE won't call `execute` of shuffle/broadcast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org