You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by GitBox <gi...@apache.org> on 2021/10/03 11:17:07 UTC

[GitHub] [ant] bodewig commented on a change in pull request #163: Make final var when is possible.

bodewig commented on a change in pull request #163:
URL: https://github.com/apache/ant/pull/163#discussion_r720811997



##########
File path: src/main/org/apache/tools/ant/taskdefs/AbstractJarSignerTask.java
##########
@@ -381,7 +381,7 @@ protected void setCommonOptions(final ExecTask cmd) {
      * @throws BuildException if the property is not correctly defined.
      */
     protected void declareSysProperty(
-        ExecTask cmd, Environment.Variable property) throws BuildException {
+            final ExecTask cmd, final Environment.Variable property) throws BuildException {

Review comment:
       why did you change indentation here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org