You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by samthebest <gi...@git.apache.org> on 2017/02/20 11:21:11 UTC
[GitHub] zeppelin pull request #2041: ZEPPELIN-2137 Changed "show line chart with foc...
GitHub user samthebest opened a pull request:
https://github.com/apache/zeppelin/pull/2041
ZEPPELIN-2137 Changed "show line chart with focus" to "zoom" so that \u2026
https://issues.apache.org/jira/browse/ZEPPELIN-2137
Improvement
### How should this be tested?
Run it, look at it (UX change)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samthebest/zeppelin patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2041.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2041
----
commit 902eba8b7427fe968a745ca007ef84de950ca717
Author: samthebest <sa...@users.noreply.github.com>
Date: 2017-02-20T11:20:05Z
ZEPPELIN-2137 Changed "show line chart with focus" to "zoom" so that it is easy to find
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2041: ZEPPELIN-2137 Changed "show line chart with focus" to ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2041
Yes, Jenkins couldn't run 'travis_check.py' because of this PR is based on folk before 'travis_check.py' exists.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2041: ZEPPELIN-2137 Changed "show line chart with focus" to ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2041
ah, yes, I didn't realize this is based of branch-0.7 - we should create PR off master instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2041: ZEPPELIN-2137 Changed "show line chart with focus" to ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2041
The change LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2041: ZEPPELIN-2137 Changed "show line chart with foc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2041
---
[GitHub] zeppelin issue #2041: ZEPPELIN-2137 Changed "show line chart with focus" to ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2041
@samthebest could you rebase this PR to get it to run CI tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2041: ZEPPELIN-2137 Changed "show line chart with focus" to ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2041
Hmm ok :)
it looks like there's an issue with the Jenkins check
```
[zeppelin-pull-request] $ /bin/bash -xe /tmp/hudson1411217650836319294.sh
+ '[' -f travis_check.py ']'
+ echo 'travis_check.py does not exists'
travis_check.py does not exists
```
@Leemoonsoo I assume this means CI tests are not actually run, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---