You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/14 02:50:05 UTC
[GitHub] [arrow-datafusion] ZuoTiJia opened a new issue, #3830: Using the window function lag causes panic.
ZuoTiJia opened a new issue, #3830:
URL: https://github.com/apache/arrow-datafusion/issues/3830
**Describe the bug**
When I create a table and use the lag window function, it panics
**To Reproduce**
```shell
DataFusion CLI v13.0.0
❯ create table foo AS values(1), (9223372036854775807);
0 rows in set. Query took 0.019 seconds.
❯ select lag(column1, column1, column1) over() from foo;
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /Users/changchengxing/.cargo/registry/src/github.com-1ecc6299db9ec823/datafusion-13.0.0/src/physical_plan/windows/mod.rs:79:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
**Additional context**
Datafusion 13.0.0
MacBook Pro Apple M1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ozankabak commented on issue #3830: Using the window function lag causes panic.
Posted by GitBox <gi...@apache.org>.
ozankabak commented on issue #3830:
URL: https://github.com/apache/arrow-datafusion/issues/3830#issuecomment-1287812727
Good catch! We will take a look at this and try to fix it early next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #3830: Using the window function lag causes panic.
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3830:
URL: https://github.com/apache/arrow-datafusion/issues/3830#issuecomment-1293611690
I think we fixed the panic here: https://github.com/apache/arrow-datafusion/pull/3963
We can file a follow on ticket to support expressions in the window size, if needed. Thanks everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #3830: Using the window function lag causes panic.
Posted by GitBox <gi...@apache.org>.
alamb closed issue #3830: Using the window function lag causes panic.
URL: https://github.com/apache/arrow-datafusion/issues/3830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ozankabak commented on issue #3830: Using the window function lag causes panic.
Posted by GitBox <gi...@apache.org>.
ozankabak commented on issue #3830:
URL: https://github.com/apache/arrow-datafusion/issues/3830#issuecomment-1290755576
Since this seems like an API issue rather than an execution issue, we will de-pri it on our end for now. We will circle back to this in the mid-term. If anyone needs it fixed in the short-term, we will be happy to provide further pointers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #3830: Using the window function lag causes panic.
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3830:
URL: https://github.com/apache/arrow-datafusion/issues/3830#issuecomment-1290839625
Thanks for the investigation @mustafasrepo and @ozankabak
Perhaps we can change the code to generate an error (rather than a panic) to more clearly explain to users what the probelm is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #3830: Using the window function lag causes panic.
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3830:
URL: https://github.com/apache/arrow-datafusion/issues/3830#issuecomment-1287760534
Thanks for the report @ZuoTiJia
cc @mustafasrepo and @ozankabak who I know have been working in this area recently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mustafasrepo commented on issue #3830: Using the window function lag causes panic.
Posted by GitBox <gi...@apache.org>.
mustafasrepo commented on issue #3830:
URL: https://github.com/apache/arrow-datafusion/issues/3830#issuecomment-1290419821
I have traced the cause of this issue. The relevant section is [here](https://github.com/apache/arrow-datafusion/blob/7559c4425e6f32655c6d09e8ed17c9c51896472b/datafusion/core/src/physical_plan/windows/mod.rs#L101) for anyone trying to solve this issue. It seems that currently there is no support for expressions for the second (offset value) and the third(default value) field of the 'lag' function. API expects these fields to be 'literal'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org