You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/08/13 23:47:17 UTC
Review Request 24669: Fixed a resource leak in ThreadLocal.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24669/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
Two issues in ThreadLocal:
(1) No release of the pthread keys upon destruction.
(2) Errors not being printed correctly, errno is not used by the pthread_ family functions.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp a20df8647844bf855ccc32b69f66d451219c8ad2
Diff: https://reviews.apache.org/r/24669/diff/
Testing
-------
Ran the ThreadLocal tests with a lot of iterations.
Thanks,
Ben Mahler
Re: Review Request 24669: Fixed a resource leak in ThreadLocal.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24669/#review50514
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 13, 2014, 9:47 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24669/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 9:47 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1700
> https://issues.apache.org/jira/browse/MESOS-1700
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Two issues in ThreadLocal:
>
> (1) No release of the pthread keys upon destruction.
> (2) Errors not being printed correctly, errno is not used by the pthread_ family functions.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp a20df8647844bf855ccc32b69f66d451219c8ad2
>
> Diff: https://reviews.apache.org/r/24669/diff/
>
>
> Testing
> -------
>
> Ran the ThreadLocal tests with a lot of iterations.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 24669: Fixed a resource leak in ThreadLocal.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24669/
-----------------------------------------------------------
(Updated Aug. 13, 2014, 9:47 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Added ticket.
Bugs: MESOS-1700
https://issues.apache.org/jira/browse/MESOS-1700
Repository: mesos-git
Description
-------
Two issues in ThreadLocal:
(1) No release of the pthread keys upon destruction.
(2) Errors not being printed correctly, errno is not used by the pthread_ family functions.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp a20df8647844bf855ccc32b69f66d451219c8ad2
Diff: https://reviews.apache.org/r/24669/diff/
Testing
-------
Ran the ThreadLocal tests with a lot of iterations.
Thanks,
Ben Mahler