You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/20 18:40:00 UTC

[jira] [Commented] (MINIFICPP-439) Allow cmake3 to take precedence over cmake in bootstrap

    [ https://issues.apache.org/jira/browse/MINIFICPP-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406848#comment-16406848 ] 

ASF GitHub Bot commented on MINIFICPP-439:
------------------------------------------

GitHub user apiri opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/287

    MINIFICPP-439 Prefer cmake3 command when available before using cmake.

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apiri/nifi-minifi-cpp MINIFICPP-439

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #287
    
----
commit c311b529f943747570d717b4f3495b087e22958b
Author: Aldrin Piri <al...@...>
Date:   2018-03-20T18:28:09Z

    MINIFICPP-439 Prefer cmake3 command when available before using cmake.

----


> Allow cmake3 to take precedence over cmake in bootstrap
> -------------------------------------------------------
>
>                 Key: MINIFICPP-439
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-439
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Aldrin Piri
>            Assignee: Aldrin Piri
>            Priority: Major
>
> For yum based distros, CMake 3+ is provided under command cmake3.  Currently bootstrap, checks for and prefers the command cmake.  This can be problematic in yum environments where both cmake and cmake3 are installed.  Inverting these, to prefer cmake3 would be helpful for such cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)