You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/07/29 17:05:12 UTC

[GitHub] [samza] cameronlee314 opened a new pull request #1118: Revert "Fixing SamzaSQL Latency Metrics resolution (#1116)"

cameronlee314 opened a new pull request #1118: Revert "Fixing SamzaSQL Latency Metrics resolution (#1116)"
URL: https://github.com/apache/samza/pull/1118
 
 
   This reverts commit ec536e14a1aa3d0fbd31c76418b605ea82c8b8d9.
   
   PR 1116 included some issues, which will be fixed in PR 1117:
   1) semantic change to return values of IncomingMessageEnvelope.getEventTime and IncomingMessageEnvelope.getArrivalTime (changed from millis to nanos) which are public API methods, and it will be hard to find existing usages to make sure they are updated properly
   2) usages of constructor of IncomingMessageEnvelope was not updated to handle nanos correctly in certain places (e.g. KafkaConsumerProxy)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services