You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/10 03:02:31 UTC

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1565: register not use metadata configuration.

LaurenceLiZhixin commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r746212830



##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -69,15 +69,15 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
 			SetGroup(config.GetApplicationConfig().Name).
 			SetVersion(version).
 			SetProxyFactoryKey(constant.DefaultKey).
-			SetMetadataType(constant.RemoteMetadataStorageType).
+			SetMetadataType(config.GetApplicationConfig().MetadataType).
 			Build()
 		exporter.ServiceConfig.Implement(exporter.metadataService)
 		err := exporter.ServiceConfig.Export()
 
-		logger.Infof("The MetadataService exports urls : %v ", exporter.ServiceConfig.GetExportedUrls())
+		logger.Infof("[Metadata Service] The MetadataService exports urls : %v ", exporter.ServiceConfig.GetExportedUrls())
 		return err
 	}
-	logger.Warnf("The MetadataService has been exported : %v ", exporter.ServiceConfig.GetExportedUrls())
+	logger.Warnf("[Metadata Service] The MetadataService has been exported : %v ", exporter.ServiceConfig.GetExportedUrls())

Review comment:
       日志这块等之后剑辉方案出来了再fix吧,我是故意写这个空格的,为了好看




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org