You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by David M <mc...@outlook.com> on 2019/05/14 15:18:29 UTC
Code Review for HIVE-14888?
All,
Can I get someone to do a quick review of the code change for HIVE-14888 (https://issues.apache.org/jira/browse/HIVE-14888)? It's a simple one-line change that has passed tests and analysis, and is ready to be pushed.
I've seen some talk about using GitHub's review functionality or other tools. Are we still following the documentation on the wiki where we do the reviews in JIRA, or is there a process change I've missed on how to formally ask for reviews?
Thanks!
David McGinnis
RE: Code Review for HIVE-14888?
Posted by David M <mc...@outlook.com>.
So I raised a PR and a code review on reviewboard two weeks ago, and no one's looked at it. Are there any committers available to take a quick look at the change for me? It's a pretty straightforward change.
https://github.com/apache/hive/pull/635
https://reviews.apache.org/r/70718/
Thanks!
-----Original Message-----
From: David M <mc...@outlook.com>
Sent: Tuesday, May 14, 2019 8:58 PM
To: dev@hive.apache.org
Subject: RE: Code Review for HIVE-14888?
Awesome, thanks Mani!
-----Original Message-----
From: Mani M <rm...@gmail.com>
Sent: Tuesday, May 14, 2019 4:48 PM
To: dev@hive.apache.org
Subject: Re: Code Review for HIVE-14888?
Hi David
Currently most of the changes is being reviewed with the help of GitHub pull request.
So update your personal fork repo and raise the pull request.
With Regards
M.Mani
+61 432 461 087
On Wed, 15 May 2019, 01:18 David M, <mc...@outlook.com> wrote:
> All,
>
> Can I get someone to do a quick review of the code change for
> HIVE-14888 (
> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FHIVE-14888&data=02%7C01%7C%7Cd0f81260a5c84eb08eab08d6d8ebc9e5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636934904541220876&sdata=IDVFhCCqLl144Tp9DMJcT2Kvbc5iD3NBIxH4mPPejGk%3D&reserved=0)? It's a simple one-line change that has passed tests and analysis, and is ready to be pushed.
>
> I've seen some talk about using GitHub's review functionality or other
> tools. Are we still following the documentation on the wiki where we
> do the reviews in JIRA, or is there a process change I've missed on
> how to formally ask for reviews?
>
> Thanks!
>
> David McGinnis
>
>
RE: Code Review for HIVE-14888?
Posted by David M <mc...@outlook.com>.
Awesome, thanks Mani!
-----Original Message-----
From: Mani M <rm...@gmail.com>
Sent: Tuesday, May 14, 2019 4:48 PM
To: dev@hive.apache.org
Subject: Re: Code Review for HIVE-14888?
Hi David
Currently most of the changes is being reviewed with the help of GitHub pull request.
So update your personal fork repo and raise the pull request.
With Regards
M.Mani
+61 432 461 087
On Wed, 15 May 2019, 01:18 David M, <mc...@outlook.com> wrote:
> All,
>
> Can I get someone to do a quick review of the code change for
> HIVE-14888 (
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FHIVE-14888&data=02%7C01%7C%7Cf5effbed5a6e4bb32d1a08d6d8c6a613%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636934745025870256&sdata=nk9OfKuRo7z7sWsx%2FN3m3w4bNxe6k0puUxuU%2BlQrNy0%3D&reserved=0)? It's a simple one-line change that has passed tests and analysis, and is ready to be pushed.
>
> I've seen some talk about using GitHub's review functionality or other
> tools. Are we still following the documentation on the wiki where we
> do the reviews in JIRA, or is there a process change I've missed on
> how to formally ask for reviews?
>
> Thanks!
>
> David McGinnis
>
>
Re: Code Review for HIVE-14888?
Posted by Mani M <rm...@gmail.com>.
Hi David
Currently most of the changes is being reviewed with the help of GitHub
pull request.
So update your personal fork repo and raise the pull request.
With Regards
M.Mani
+61 432 461 087
On Wed, 15 May 2019, 01:18 David M, <mc...@outlook.com> wrote:
> All,
>
> Can I get someone to do a quick review of the code change for HIVE-14888 (
> https://issues.apache.org/jira/browse/HIVE-14888)? It's a simple one-line
> change that has passed tests and analysis, and is ready to be pushed.
>
> I've seen some talk about using GitHub's review functionality or other
> tools. Are we still following the documentation on the wiki where we do the
> reviews in JIRA, or is there a process change I've missed on how to
> formally ask for reviews?
>
> Thanks!
>
> David McGinnis
>
>