You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by st...@apache.org on 2011/11/01 19:27:54 UTC
svn commit: r1196193 -
/myfaces/extensions/cdi/trunk/jee-modules/jsf20-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf2/impl/scope/conversation/JsfRestParameters.java
Author: struberg
Date: Tue Nov 1 18:27:54 2011
New Revision: 1196193
URL: http://svn.apache.org/viewvc?rev=1196193&view=rev
Log:
EXTCDI-232 sort view parameters for reproducible results
Modified:
myfaces/extensions/cdi/trunk/jee-modules/jsf20-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf2/impl/scope/conversation/JsfRestParameters.java
Modified: myfaces/extensions/cdi/trunk/jee-modules/jsf20-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf2/impl/scope/conversation/JsfRestParameters.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/jee-modules/jsf20-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf2/impl/scope/conversation/JsfRestParameters.java?rev=1196193&r1=1196192&r2=1196193&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/jee-modules/jsf20-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf2/impl/scope/conversation/JsfRestParameters.java (original)
+++ myfaces/extensions/cdi/trunk/jee-modules/jsf20-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf2/impl/scope/conversation/JsfRestParameters.java Tue Nov 1 18:27:54 2011
@@ -31,6 +31,7 @@ import javax.faces.view.ViewMetadata;
import java.io.Serializable;
import java.util.Collection;
import java.util.HashMap;
+import java.util.TreeSet;
/**
* This class holds information about the last used RestParameters for a given JSF view.
@@ -112,9 +113,18 @@ public class JsfRestParameters extends R
{
Collection<UIViewParameter> currentViewParams = ViewMetadata.getViewParameters(facesContext.getViewRoot());
StringBuilder sb = new StringBuilder();
+
+ // for sorting the view params
+ TreeSet<String> viewParamNames = new TreeSet<String>();
+
for (UIViewParameter viewParameter : currentViewParams)
{
String viewParamName = viewParameter.getName();
+ viewParamNames.add(viewParamName);
+ }
+
+ for (String viewParamName : viewParamNames)
+ {
String viewParamValue = facesContext.getExternalContext().getRequestParameterMap().get(viewParamName);
if (viewParamValue == null)
{