You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/14 19:01:53 UTC

[kudu-CR](branch-1.1.x) [c++ client] temporary fix for KUDU-1688 

Hello Todd Lipcon, Kudu Jenkins,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5072

to review the following change.

Change subject: [c++ client] temporary fix for KUDU-1688
......................................................................

[c++ client] temporary fix for KUDU-1688

KUDU-1688 Impala 'INSERT IGNORE' is slow due to VLOG(1) logging in
  client

Increased level for verbose log messages on per-row errors output by
batcher.

Change-Id: I61f039e94df130c225e0bb6a07f86200426c470a
Reviewed-on: http://gerrit.cloudera.org:8080/5067
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/client/batcher.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/5072/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61f039e94df130c225e0bb6a07f86200426c470a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR](branch-1.1.x) [c++ client] temporary fix for KUDU-1688

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: [c++ client] temporary fix for KUDU-1688
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5072/1//COMMIT_MSG
Commit Message:

Line 9: KUDU-1688 Impala 'INSERT IGNORE' is slow due to VLOG(1) logging in
nit: in the future can you put this line first in the commit message so it's clearer what the fix is when looking at single-line git log output?


-- 
To view, visit http://gerrit.cloudera.org:8080/5072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61f039e94df130c225e0bb6a07f86200426c470a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR](branch-1.1.x) [c++ client] temporary fix for KUDU-1688

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: [c++ client] temporary fix for KUDU-1688
......................................................................


[c++ client] temporary fix for KUDU-1688

KUDU-1688 Impala 'INSERT IGNORE' is slow due to VLOG(1) logging in
  client

Increased level for verbose log messages on per-row errors output by
batcher.

Change-Id: I61f039e94df130c225e0bb6a07f86200426c470a
Reviewed-on: http://gerrit.cloudera.org:8080/5067
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-on: http://gerrit.cloudera.org:8080/5072
---
M src/kudu/client/batcher.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61f039e94df130c225e0bb6a07f86200426c470a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>