[jira] [Commented] (HDDS-5614) The OzoneClient in s3 endpoint is not closed correctly

["Attila Doroszlai (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDDS-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400276#comment-17400276 ] 

Attila Doroszlai commented on HDDS-5614:
----------------------------------------

[~szetszwo], can you please share the steps to reproduce the case when {{client}} field gets overwritten?  I have tried with both {{awscli}} and {{warp}}, and it did not occur.  If I understand correctly, that's because {{OzoneClientProducer}} is {{@RequestScoped}}.

> The OzoneClient in s3 endpoint is not closed correctly
> ------------------------------------------------------
>
>                 Key: HDDS-5614
>                 URL: https://issues.apache.org/jira/browse/HDDS-5614
>             Project: Apache Ozone
>          Issue Type: Bug
>          Components: S3
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Major
>
> In [~kerneltime]'s S3 tests, we found that the close() method in EndpointBase.client, which is an OzoneClient, is never called.
> In OzoneClientProducer, client.close() is called in the destroy() method. However, the createClient() method keeps overwriting the "client" field. Only the last client will be closed.
> {code:java}
> //OzoneClientProducer.java
>   @Produces
>   public OzoneClient createClient() throws WebApplicationException,
>       IOException {
>     client = getClient(ozoneConfiguration);
>     return client;
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org