You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by "Sumit Mohanty (JIRA)" <ji...@apache.org> on 2013/04/26 22:40:15 UTC

[jira] [Commented] (AMBARI-2036) Global configurations not sent with a status_command to agents

    [ https://issues.apache.org/jira/browse/AMBARI-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643228#comment-13643228 ] 

Sumit Mohanty commented on AMBARI-2036:
---------------------------------------

LGTM. +1.

Minor nit for future refactoring consideration: The logic to traverse the config hierarchy (and the additional logic to read full config at service level) could be re-factored to a common class. It seems that we have the logic in few places. We need few helper methods that cover (1) get config of type X (e.g. global) at certain level and (2) get all configs at certain level.
                
> Global configurations not sent with a status_command to agents
> --------------------------------------------------------------
>
>                 Key: AMBARI-2036
>                 URL: https://issues.apache.org/jira/browse/AMBARI-2036
>             Project: Ambari
>          Issue Type: Bug
>    Affects Versions: 1.3.0
>            Reporter: Nate Cole
>            Assignee: Nate Cole
>             Fix For: 1.3.0
>
>         Attachments: AMBARI-2036.patch
>
>
> When formulating a STATUS_COMMAND to send to an agent, the code is currently only looking for services.  Must follow the same pattern as for EXECUTE_COMMANDs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira