You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by dcarbone <gi...@git.apache.org> on 2016/06/14 19:10:41 UTC
[GitHub] cloudstack pull request #1591: Updating Alert codes
GitHub user dcarbone opened a pull request:
https://github.com/apache/cloudstack/pull/1591
Updating Alert codes
Updating codes per values present here: https://github.com/apache/cloudstack/blob/4.8/api/src/org/apache/cloudstack/alert/AlertService.java#L39
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/myENA/cloudstack alert-response-doc-update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1591
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@rhtyd @dcarbone given that we are trying to get a 4.8 RC cut ASAP (we are week late already), I think it is best to push this PR to 4.9.2.0. Would you mind re-pointing it to the 4.9 branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1591
I would like to get this PR merged as part of the 4.8.2.0 release, but we don't have much time to get it completed.
@dcarbone could you please create a JIRA ticket explaining the bug/enhancement motivation of this PR? Also, could you please investigate the cause of the Travis build failure?
@rhtyd were you able to complete your analysis?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@dcarbone can you squash your commits and rebase against latest, thanks. Please also amend git commit message to include the JIRA ID.
@jburwell I did not start my analysis, I'll do that once we've sorted out above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@rhtyd have you had a chance to analyze? I would like to include this change in 4.9.1.0 and 4.10.0.0 for which we are planning to cut RCs on 25 Sept 2016.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1591
Can maybe @rhtyd comment on this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@dcarbone thanks for creating a JIRA ticket. Could you please prepend the headline of your commit message with the ticket ID (i.e. [CLOUDSTACK-9468])? Additionally, the Travis build is failing. Could you please investigate the cause and fix it?
/cc @rhtyd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by dcarbone <gi...@git.apache.org>.
Github user dcarbone commented on the issue:
https://github.com/apache/cloudstack/pull/1591
squashed, pointing at 4.9, and commit amended.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@jburwell we can merge this, since it's a doc change no tests are needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1591: Updating Alert codes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1591
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1591
LGTM @jburwell I checked the changes against the values defined in `AlertService` and they check out perfectly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by dcarbone <gi...@git.apache.org>.
Github user dcarbone commented on the issue:
https://github.com/apache/cloudstack/pull/1591
@jburwell: JIRA ticket created: https://issues.apache.org/jira/browse/CLOUDSTACK-9468
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1591
LGTM, this is only a comment change. Changes have been verified, so I'll proceed with merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1591: Updating Alert codes
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1591
We'll need to check this against the consumers of the response, based on present alert codes we may need to update it. We'll also need to see when the alert code diverged, why some of the alert codes changed (for example HOST etc.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---