You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2018/05/17 01:41:18 UTC
Review Request 67178: RANGER-2104: Ranger tagsync should ignore
ENTITY_UPDATE events if the updated entity does not have associated traits
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67178/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-2104
https://issues.apache.org/jira/browse/RANGER-2104
Repository: ranger
Description
-------
Tagsync may receive a large number of ENTITY_UPDATE events when used in a large EDW environment. If an update entity is not associated with any tags (aka traits, classifications), then this event does not have material impact on the resource->tag associations in the Ranger, and therefore, can be safely dropped. Processing such event adds processing overhead to tagsync, ranger-admin and network, and also causes ranger-admin database to be populated with service-resource that is not tagged and is not needed for access evaluation.
Diffs
-----
pom.xml c7632bac9
src/main/assembly/tagsync.xml 0b17151b9
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java f007ae55e
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java c382db018
Diff: https://reviews.apache.org/r/67178/diff/1/
Testing
-------
Tested with local VM
Thanks,
Abhay Kulkarni
Re: Review Request 67178: RANGER-2104: Ranger tagsync should ignore
ENTITY_UPDATE events if the updated entity does not have associated traits
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67178/#review203345
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 17, 2018, 3:13 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67178/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 3:13 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-2104
> https://issues.apache.org/jira/browse/RANGER-2104
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Tagsync may receive a large number of ENTITY_UPDATE events when used in a large EDW environment. If an update entity is not associated with any tags (aka traits, classifications), then this event does not have material impact on the resource->tag associations in the Ranger, and therefore, can be safely dropped. Processing such event adds processing overhead to tagsync, ranger-admin and network, and also causes ranger-admin database to be populated with service-resource that is not tagged and is not needed for access evaluation.
>
>
> Diffs
> -----
>
> pom.xml c7632bac9
> src/main/assembly/tagsync.xml 0b17151b9
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java f007ae55e
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java c382db018
>
>
> Diff: https://reviews.apache.org/r/67178/diff/2/
>
>
> Testing
> -------
>
> Tested with local VM
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 67178: RANGER-2104: Ranger tagsync should ignore
ENTITY_UPDATE events if the updated entity does not have associated traits
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67178/
-----------------------------------------------------------
(Updated May 17, 2018, 3:13 a.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Addressed review comment.
Bugs: RANGER-2104
https://issues.apache.org/jira/browse/RANGER-2104
Repository: ranger
Description
-------
Tagsync may receive a large number of ENTITY_UPDATE events when used in a large EDW environment. If an update entity is not associated with any tags (aka traits, classifications), then this event does not have material impact on the resource->tag associations in the Ranger, and therefore, can be safely dropped. Processing such event adds processing overhead to tagsync, ranger-admin and network, and also causes ranger-admin database to be populated with service-resource that is not tagged and is not needed for access evaluation.
Diffs (updated)
-----
pom.xml c7632bac9
src/main/assembly/tagsync.xml 0b17151b9
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java f007ae55e
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java c382db018
Diff: https://reviews.apache.org/r/67178/diff/2/
Changes: https://reviews.apache.org/r/67178/diff/1-2/
Testing
-------
Tested with local VM
Thanks,
Abhay Kulkarni
Re: Review Request 67178: RANGER-2104: Ranger tagsync should ignore
ENTITY_UPDATE events if the updated entity does not have associated traits
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
> On May 17, 2018, 2:31 a.m., Madhan Neethiraj wrote:
> > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java
> > Lines 233 (patched)
> > <https://reviews.apache.org/r/67178/diff/1/?file=2024610#file2024610line233>
> >
> > lines #233 - #243 should go outside 'if' block that starts at #224, so that the message will be committed even if notification is null.
Fixed. Also removed lines 182-187 and subsequent check for notification != null, for the same reason.
- Abhay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67178/#review203307
-----------------------------------------------------------
On May 17, 2018, 1:41 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67178/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 1:41 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-2104
> https://issues.apache.org/jira/browse/RANGER-2104
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Tagsync may receive a large number of ENTITY_UPDATE events when used in a large EDW environment. If an update entity is not associated with any tags (aka traits, classifications), then this event does not have material impact on the resource->tag associations in the Ranger, and therefore, can be safely dropped. Processing such event adds processing overhead to tagsync, ranger-admin and network, and also causes ranger-admin database to be populated with service-resource that is not tagged and is not needed for access evaluation.
>
>
> Diffs
> -----
>
> pom.xml c7632bac9
> src/main/assembly/tagsync.xml 0b17151b9
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java f007ae55e
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java c382db018
>
>
> Diff: https://reviews.apache.org/r/67178/diff/1/
>
>
> Testing
> -------
>
> Tested with local VM
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 67178: RANGER-2104: Ranger tagsync should ignore
ENTITY_UPDATE events if the updated entity does not have associated traits
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67178/#review203307
-----------------------------------------------------------
Fix it, then Ship it!
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java
Lines 233 (patched)
<https://reviews.apache.org/r/67178/#comment285415>
lines #233 - #243 should go outside 'if' block that starts at #224, so that the message will be committed even if notification is null.
- Madhan Neethiraj
On May 17, 2018, 1:41 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67178/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 1:41 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-2104
> https://issues.apache.org/jira/browse/RANGER-2104
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Tagsync may receive a large number of ENTITY_UPDATE events when used in a large EDW environment. If an update entity is not associated with any tags (aka traits, classifications), then this event does not have material impact on the resource->tag associations in the Ranger, and therefore, can be safely dropped. Processing such event adds processing overhead to tagsync, ranger-admin and network, and also causes ranger-admin database to be populated with service-resource that is not tagged and is not needed for access evaluation.
>
>
> Diffs
> -----
>
> pom.xml c7632bac9
> src/main/assembly/tagsync.xml 0b17151b9
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java f007ae55e
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java c382db018
>
>
> Diff: https://reviews.apache.org/r/67178/diff/1/
>
>
> Testing
> -------
>
> Tested with local VM
>
>
> Thanks,
>
> Abhay Kulkarni
>
>