You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/01 08:59:36 UTC

[GitHub] [skywalking-java] wu-sheng commented on pull request #135: add SAMPLE_AVG_CPU_LOAD_LIMIT config

wu-sheng commented on pull request #135:
URL: https://github.com/apache/skywalking-java/pull/135#issuecomment-1085638278


   Take a look at how `TraceIgnoreExtendService` extends from `SamplingService`. I think it would be more elegant.
   This doesn't have to change from the core level.
   
   Another thing is, you add another thread just for CPU usage, which concerns me much. The agent is very sensitive about a new thread. It should be more reasonable to ask `JVMService` holds the latest CPU value, and provide a method for this new plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org