You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juergen Donnerstag (JIRA)" <ji...@apache.org> on 2009/11/08 11:44:32 UTC

[jira] Commented: (WICKET-2541) FormComponents hidden by wicket:enclosure should not be validated upon form submit

    [ https://issues.apache.org/jira/browse/WICKET-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774756#action_12774756 ] 

Juergen Donnerstag commented on WICKET-2541:
--------------------------------------------

I did some tests and don't get it going. Not restoring the state means that onBeforeRender will not be called on the next request if visibility was set to false. Whatever we tried so far, and that is true for all transparent components, failed because of subtle differences (onBeforeRender, validation, etc.) during execution. 

That leads to auto-components re-parenting their children. But that only causes new problems. 

I wonder whether we should rather keep the enclosure implementation simply and provide a EnclosureContainer as fallback together with some clear guidelines when to use wicket:enclosure and when not. May be we can autodetect dangerous situations and log a warning.

> FormComponents hidden by wicket:enclosure should not be validated upon form submit
> ----------------------------------------------------------------------------------
>
>                 Key: WICKET-2541
>                 URL: https://issues.apache.org/jira/browse/WICKET-2541
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.3
>            Reporter: Christian Oldiges
>            Assignee: Juergen Donnerstag
>            Priority: Minor
>
> FormComponents that are hidden by an enclosing wicket:enclosure tag should not by validated.
> If there is a form with 2 form components A and B and an enclosure is used to hide both A and B and it is controlled by B.isVisible (wicket:enclosure child="B"), the FormComponent A is still validated.
> Simple example: a RequiredTextField is still required even if made invisible by a surrounding enclosure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.