You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/06/17 13:41:58 UTC
Review Request: CLOUDSTACK-1047: tracking in logs using job id
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11906/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Sateesh Chodapuneedi.
Description
-------
CLOUDSTACK-1047: tracking in logs using job id
https://issues.apache.org/jira/browse/CLOUDSTACK-1047
This addresses bug CLOUDSTACK-1047.
Diffs
-----
server/src/com/cloud/async/AsyncJobManagerImpl.java 0101a8a
server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb
Diff: https://reviews.apache.org/r/11906/diff/
Testing
-------
Tests:
1. Deploy an Instance.
2. In the Management server logs, check the async job description, it should be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ]
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUDSTACK-1047: tracking in logs using job id
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11906/#review22043
-----------------------------------------------------------
server/src/com/cloud/async/AsyncJobManagerImpl.java
<https://reviews.apache.org/r/11906/#comment45380>
it would help if you just keep it as job-id because thats how we log it in the logs...would be consistent for someone grepping for logs using job-id
server/src/com/cloud/async/AsyncJobManagerImpl.java
<https://reviews.apache.org/r/11906/#comment45379>
can this be put in the check above starting with
if (job != null) {
server/src/com/cloud/async/AsyncJobManagerImpl.java
<https://reviews.apache.org/r/11906/#comment45381>
As said above please keep it as job-id
server/src/com/cloud/async/AsyncJobManagerImpl.java
<https://reviews.apache.org/r/11906/#comment45382>
what if jobuuid = null
- Nitin Mehta
On June 17, 2013, 11:41 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11906/
> -----------------------------------------------------------
>
> (Updated June 17, 2013, 11:41 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> CLOUDSTACK-1047: tracking in logs using job id
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-1047
>
>
> This addresses bug CLOUDSTACK-1047.
>
>
> Diffs
> -----
>
> server/src/com/cloud/async/AsyncJobManagerImpl.java 0101a8a
> server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb
>
> Diff: https://reviews.apache.org/r/11906/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an Instance.
> 2. In the Management server logs, check the async job description, it should be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ]
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 11906: CLOUDSTACK-1047: tracking in logs using job id
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11906/#review22580
-----------------------------------------------------------
LGTM but clutters the log up quite a bit.
- Prasanna Santhanam
On June 18, 2013, 7:07 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11906/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 7:07 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-1047
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1047: tracking in logs using job id
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-1047
>
>
> Diffs
> -----
>
> server/src/com/cloud/async/AsyncJobManagerImpl.java 0101a8a
> server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb
>
> Diff: https://reviews.apache.org/r/11906/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an Instance.
> 2. In the Management server logs, check the async job description, it should be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ]
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 11906: CLOUDSTACK-1047: tracking in logs using job id
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11906/#review22903
-----------------------------------------------------------
Patch doesn't apply cleanly on master. Can you verify and share an updated patch.
- Devdeep Singh
On July 1, 2013, 2:50 p.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11906/
> -----------------------------------------------------------
>
> (Updated July 1, 2013, 2:50 p.m.)
>
>
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1047
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1047: tracking in logs using job id
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-1047
>
>
> Diffs
> -----
>
> server/src/com/cloud/async/AsyncJobManagerImpl.java 0101a8a
> server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb
>
> Diff: https://reviews.apache.org/r/11906/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an Instance.
> 2. In the Management server logs, check the async job description, it should be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ]
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 11906: CLOUDSTACK-1047: tracking in logs using job id
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11906/#review22997
-----------------------------------------------------------
Commit 2ac8f2b4525d664c9e44a9846cd688020df5cc72 in branch refs/heads/4.2 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2ac8f2b ]
CLOUDSTACK-1047: tracking in logs using job id.
- ASF Subversion and Git Services
On July 10, 2013, 7:03 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11906/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 7:03 a.m.)
>
>
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1047
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1047: tracking in logs using job id
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-1047
>
>
> Diffs
> -----
>
> server/src/com/cloud/async/AsyncJobManagerImpl.java 37b9727
> server/src/com/cloud/storage/VolumeManagerImpl.java 4b76dff
>
> Diff: https://reviews.apache.org/r/11906/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an Instance.
> 2. In the Management server logs, check the async job description, it should be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ]
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 11906: CLOUDSTACK-1047: tracking in logs using job id
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11906/#review22995
-----------------------------------------------------------
Commit 2e8d16b36549d6364ed0b4e54b095c7101d64e7c in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2e8d16b ]
CLOUDSTACK-1047: tracking in logs using job id.
- ASF Subversion and Git Services
On July 10, 2013, 7:03 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11906/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 7:03 a.m.)
>
>
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1047
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1047: tracking in logs using job id
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-1047
>
>
> Diffs
> -----
>
> server/src/com/cloud/async/AsyncJobManagerImpl.java 37b9727
> server/src/com/cloud/storage/VolumeManagerImpl.java 4b76dff
>
> Diff: https://reviews.apache.org/r/11906/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an Instance.
> 2. In the Management server logs, check the async job description, it should be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ]
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 11906: CLOUDSTACK-1047: tracking in logs using job id
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11906/#review22998
-----------------------------------------------------------
Ship it!
Committed the changes to master and 4.2. Kindly close the request.
- Devdeep Singh
On July 10, 2013, 7:03 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11906/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 7:03 a.m.)
>
>
> Review request for cloudstack, Alex Huang, Devdeep Singh, and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1047
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1047: tracking in logs using job id
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-1047
>
>
> Diffs
> -----
>
> server/src/com/cloud/async/AsyncJobManagerImpl.java 37b9727
> server/src/com/cloud/storage/VolumeManagerImpl.java 4b76dff
>
> Diff: https://reviews.apache.org/r/11906/diff/
>
>
> Testing
> -------
>
> Tests:
> 1. Deploy an Instance.
> 2. In the Management server logs, check the async job description, it should be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ]
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request 11906: CLOUDSTACK-1047: tracking in logs using job id
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11906/
-----------------------------------------------------------
(Updated July 10, 2013, 7:03 a.m.)
Review request for cloudstack, Alex Huang, Devdeep Singh, and Nitin Mehta.
Changes
-------
Updated patch, created on the top of latest master.
Bugs: CLOUDSTACK-1047
Repository: cloudstack-git
Description
-------
CLOUDSTACK-1047: tracking in logs using job id
https://issues.apache.org/jira/browse/CLOUDSTACK-1047
Diffs (updated)
-----
server/src/com/cloud/async/AsyncJobManagerImpl.java 37b9727
server/src/com/cloud/storage/VolumeManagerImpl.java 4b76dff
Diff: https://reviews.apache.org/r/11906/diff/
Testing
-------
Tests:
1. Deploy an Instance.
2. In the Management server logs, check the async job description, it should be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ]
Thanks,
Sanjay Tripathi
Re: Review Request 11906: CLOUDSTACK-1047: tracking in logs using job id
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11906/
-----------------------------------------------------------
(Updated July 1, 2013, 2:50 p.m.)
Review request for cloudstack, Alex Huang, Devdeep Singh, and Nitin Mehta.
Bugs: CLOUDSTACK-1047
Repository: cloudstack-git
Description
-------
CLOUDSTACK-1047: tracking in logs using job id
https://issues.apache.org/jira/browse/CLOUDSTACK-1047
Diffs
-----
server/src/com/cloud/async/AsyncJobManagerImpl.java 0101a8a
server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb
Diff: https://reviews.apache.org/r/11906/diff/
Testing
-------
Tests:
1. Deploy an Instance.
2. In the Management server logs, check the async job description, it should be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ]
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUDSTACK-1047: tracking in logs using job id
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11906/
-----------------------------------------------------------
(Updated June 18, 2013, 7:07 a.m.)
Review request for cloudstack, Devdeep Singh, Nitin Mehta, and Sateesh Chodapuneedi.
Changes
-------
Updated patch after incorporating review comments.
Description
-------
CLOUDSTACK-1047: tracking in logs using job id
https://issues.apache.org/jira/browse/CLOUDSTACK-1047
This addresses bug CLOUDSTACK-1047.
Diffs (updated)
-----
server/src/com/cloud/async/AsyncJobManagerImpl.java 0101a8a
server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb
Diff: https://reviews.apache.org/r/11906/diff/
Testing
-------
Tests:
1. Deploy an Instance.
2. In the Management server logs, check the async job description, it should be somthing like: job-[ 22 ] = [ 1075d499-03a8-44c3-ac9e-348dc5b32ba1 ]
Thanks,
Sanjay Tripathi