[jira] [Commented] (ZOOKEEPER-1628) Documented list of allowable characters in ZK doc not in line with code

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561662#comment-13561662 ] 

Hadoop QA commented on ZOOKEEPER-1628:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12566311/ZOOKEEPER-1628.patch
  against trunk revision 1437257.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 14 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1359//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1359//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1359//console

This message is automatically generated.
                
> Documented list of allowable characters in ZK doc not in line with code
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1628
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1628
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: documentation, java client
>            Reporter: Gabriel Reid
>         Attachments: ZOOKEEPER-1628.patch
>
>
> The documented set of allowable characters in ZooKeeper node names in the Programmer's Guide is not entirely in line with the code.
> The range of non-printable ASCII characters in the doc ends too early (i.e. 0x19 instead of 0x1F).
> The range checking code in PathUtils also includes off-by-one errors, so that characters that are on the border of being unallowable are actually allowed by the code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira